Skip to content

Conversation

LifeIsAParadox
Copy link
Member

  • with this change MRREADME.md is synched with Modrinth description every time the mod gets uploaded to Modrinth.
  • added emi as optional dependency

I only copied the Modrinth description to MRREADME.md. This can be changed after this pr.

- with this change the mrreadme is synched with modrinth description everytime the mod gets uploaded to modrinth.
- Also added emi to optional list
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want to note that later this year discord will begin enforcing that CDN links contain the necessary authorization parameters in order to be able to access the content. So I would recommend that assets hosted on discord are moved to be hosted somewhere else, ideally on a static GitHub repo or on hysky.de

@kevinthegreat1 kevinthegreat1 added the merge me please Pull requests that are ready to merge label Oct 7, 2023
@kevinthegreat1 kevinthegreat1 merged commit 5ca4287 into SkyblockerMod:master Oct 8, 2023
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants