Item Rarity Backgrounds #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
force-pushed
the
item-rarity-background
branch
from
677b14f to
05d86bf
Compare
kevinthegreat1
added
reviews needed
src/main/java/me/xmrvizzy/skyblocker/skyblock/item/ItemRarityBackgrounds.java
Outdated
Show resolved
Hide resolved
kevinthegreat1
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you've enabled the feature, then depending on the rarity of the item a coloured background will be drawn behind it to represent the rarity. The background texture is a regular texture so people can customize it with resource packs if they wish to.
I've also done my best to ensure a minimal performance loss as a result of needing to search the lore for the item's rarity.
The background texture is a modified version of the one from the discontinued mod SkyblockCatia (The circle looks pretty nice and goes well with the slot lock texture)