Hook actual durability for Pickonimbus/Drills #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
better-durability
branch
from
a7820f1 to
f9c7815
Compare
AzureAaron
requested changes
Oct 7, 2023
src/main/java/me/xmrvizzy/skyblocker/mixin/DrawContextMixin.java
Outdated
Show resolved
Hide resolved
Instead of the previous DrawContext hack. Confirmed working with Durability Notifier on Fabric 1.20.2.
ghost
force-pushed
the
better-durability
branch
from
f9c7815 to
95faf14
Compare
kevinthegreat1
requested changes
Oct 7, 2023
kevinthegreat1
added
changes requested
Co-authored-by: Kevin <92656833+kevinthegreat1@users.noreply.github.com>
|
All suggestions should be applied now (I recommend squash merging to avoid unnecessary commits). |
kevinthegreat1
previously approved these changes
Oct 7, 2023
kevinthegreat1
added
merge me please
AzureAaron
previously approved these changes
Oct 9, 2023
LifeIsAParadox
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I recommend using "Squash and merge" when merging this pull request to avoid an unclean commit history.
Instead of the previous DrawContext hack.
Confirmed working with Durability Notifier on Fabric 1.20.2.