Skip to content

Add Support for Custom toString Function for Enum Dropdowns #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2023
Merged

Add Support for Custom toString Function for Enum Dropdowns #344

merged 2 commits into from
Oct 8, 2023

Conversation

kevinthegreat1
Copy link
Collaborator

Removed the no longer-needed wrapper enum around Formatting to override the toString method. Instead, a custom toString method is provided to the controller builder.

@kevinthegreat1 kevinthegreat1 added the reviews needed This PR needs reviews label Oct 8, 2023
AzureAaron
AzureAaron previously approved these changes Oct 8, 2023
View reviewed changes
@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 8, 2023
@kevinthegreat1 kevinthegreat1 merged commit 0c93811 into SkyblockerMod:master Oct 8, 2023
@kevinthegreat1 kevinthegreat1 deleted the yacl3-enum-dropdown branch October 8, 2023 04:01
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinthegreat1 @AzureAaron