Batched Rendering + Future Sodium Compat #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with Sodium's upcoming RenderSystem access restrictions.
|
After some fixes and improvements this is ready for review. |
kevinthegreat1
force-pushed
the
batched-rendering
branch
from
392068c to
4828dd7
Compare
kevinthegreat1
previously approved these changes
Nov 14, 2023
kevinthegreat1
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rendering of filled boxes is now batched meaning that all filled boxes are rendered in a single draw call as opposed to rendering each individual box in its own draw call. This gives approximately a 4x (~8% to ~2% of render thread tick) performance boost when rendering quite a few filled boxes per frame.
This also batches the rendering of beacon beams, improving performance by ~4.8x (~34% to ~7% of render thread tick) when many are in view.
Also adds compatibility for Sodium's brand new
DeferredRenderTaskclass which replacesrecordRenderCallas in Sodium 0.5.4 calling that method will result in an exception being thrown. CaffeineMC/sodium@bc3c47b