Add Wither & Blood Door Highlight #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
added
new feature
AzureAaron
requested changes
Nov 23, 2023
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/Room.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonSecrets.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/categories/DungeonsCategory.java
Show resolved
Hide resolved
AzureAaron
added
changes requested
kevinthegreat1
added
reviews needed
AzureAaron
approved these changes
Nov 23, 2023
AzureAaron
added
merge me please
|
zzz |
|
Seems to work fine, however sometimes when I get the key the highlight stays red. |
|
Also when I enter the fairy room with a key it always seems to be red |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Wither & Blood Door Highlight!
Known bugs:
Some key pickups by other players are not detected. (When the player entity is not loaded or when the key is obtained in a room not yet visited by the client's player.)
Wither door in the fairy room always remains locked since no key can ever be picked up in the fairy room.