Skip to content

Conversation

AzureAaron
Copy link
Collaborator

These exceptions seem to be triggered in dungeons as a result of sending invalid data in entity packets, and for some reason when the exceptions are left unchecked they cause lag spikes.

Let's take moment to congratulate Hypixel on their W multi-version support!

These exceptions seem to be triggered in dungeons as a result of sending
invalid data in entity packets, and for some reason when the exceptions
are left unchecked they cause lag spikes.
@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Dec 12, 2023
@kevinthegreat1
Copy link
Collaborator

Can you just cancel the method before throwing in copyToFrom instead of catching its errors.

@AzureAaron
Copy link
Collaborator Author

Can you just cancel the method before throwing in copyToFrom instead of catching its errors.

Done.

@AzureAaron AzureAaron changed the title Ignore invalid entity data exceptions Ignore invalid entity data exceptions & broken quiz question Dec 13, 2023
@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Dec 15, 2023
@AzureAaron AzureAaron merged commit 8900e7c into SkyblockerMod:master Dec 15, 2023
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Dec 15, 2023
@AzureAaron AzureAaron deleted the performance-fix branch December 15, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants