Skip to content

Conversation

btwonion
Copy link
Contributor

hi,
i added a built-in texture pack which atm only contains a recolored tripwire(-hook):
image

i named the pack "recolored_dungeon_items" because i think there will come more textures in the future. (maybe)

@kevinthegreat1
Copy link
Collaborator

Thanks for your PR. However, I would prefer the model and block states to be datagen'ed.

@kevinthegreat1 kevinthegreat1 added the changes requested This PR need changes label Dec 19, 2023
@btwonion
Copy link
Contributor Author

i thought it might be easier for the users to use a resourcepack, so they can decide whether to use it or not

@kevinthegreat1
Copy link
Collaborator

Yes, I mean datagen the resource pack. See https://fabricmc.net/wiki/tutorial:datagen_setup and FabricDataGenerator.createBuiltinResourcePack.

@btwonion
Copy link
Contributor Author

oh okay. i will take a look at it

@kevinthegreat1
Copy link
Collaborator

I can help with this if you have any problems, or I can just do it.

@btwonion
Copy link
Contributor Author

i currently do not have the time to do it. especially because im totally new to this. if you want to you can do it, but we can change this pr to a draft and i will do it later.

@btwonion btwonion marked this pull request as draft December 29, 2023 19:28
@btwonion
Copy link
Contributor Author

i was able to recreate the blockstate configuration and the model.
the problem is, that i cannot find a proper way to datagen the element section of the model.

i furthermore removed the powered, attached and the tripwire hook configurations as in the dungeons there simply are no tripwire hooks and i dont think anybody would care about different textures for them in the use case here.

i left the old model and blockstate in the resources as a reference

@kevinthegreat1
Copy link
Collaborator

Thanks, I will take a look soon.

@AzureAaron AzureAaron added this to the 1.17 milestone Jan 10, 2024
@kevinthegreat1 kevinthegreat1 self-assigned this Jan 12, 2024
@kevinthegreat1 kevinthegreat1 added wip This PR is a work in progress and removed changes requested This PR need changes labels Jan 12, 2024
@kevinthegreat1 kevinthegreat1 force-pushed the add-tripwire-visibility branch from 2345db9 to 1af64a2 Compare January 13, 2024 23:27
@kevinthegreat1 kevinthegreat1 marked this pull request as ready for review January 13, 2024 23:28
@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews new feature This issue or PR is a new feature and removed wip This PR is a work in progress labels Jan 13, 2024
@kevinthegreat1 kevinthegreat1 removed their assignment Jan 13, 2024
@btwonion
Copy link
Contributor Author

waiiiiitt. haven't i pushed it?

@btwonion
Copy link
Contributor Author

i had the whole thing recoded to datagen, but i forgot to push... and reset my system cause of a new component to my pc.

@kevinthegreat1
Copy link
Collaborator

Yes you did push it. I overrode those commits and reverted it since I couldn’t figure out datagen either. I have a copy of your commits and if you want those I can push them somewhere for you.

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 14, 2024
@kevinthegreat1 kevinthegreat1 merged commit 0c94fbc into SkyblockerMod:master Jan 14, 2024
@kevinthegreat1
Copy link
Collaborator

Thanks for contributing!

@btwonion btwonion deleted the add-tripwire-visibility branch January 14, 2024 20:07
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants