Skip to content

Durability Fix #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 1, 2024
Merged

Durability Fix #465

merged 4 commits into from
Jan 1, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

Fixes #459.
Also adds a test.

@kevinthegreat1 kevinthegreat1 added the reviews needed This PR needs reviews label Dec 31, 2023
AzureAaron
AzureAaron previously approved these changes Dec 31, 2023
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question though why is the item stack accessor applied both client and server side?

@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Dec 31, 2023
@AzureAaron AzureAaron merged commit c6a2463 into SkyblockerMod:master Jan 1, 2024
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 1, 2024
@kevinthegreat1 kevinthegreat1 deleted the durability-fix branch January 1, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drill fuel feature conflicts with any durability viewer mod
2 participants
@kevinthegreat1 @AzureAaron