Skip to content

Conversation

AzureAaron
Copy link
Collaborator

Corrects transparent pixels in skins, since it cancels out the effects of the stripAlpha method a small warning was added to the description but it probably shouldn't affect other skins/heads. If the language could be improved let me know.

Resolves #425

@AzureAaron AzureAaron added reviews needed This PR needs reviews new feature This issue or PR is a new feature labels Dec 31, 2023
kevinthegreat1
kevinthegreat1 previously approved these changes Dec 31, 2023
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe make it enabled by default?

@AzureAaron
Copy link
Collaborator Author

Looks good, maybe make it enabled by default?

Yeah I'll do that since its a visual enhancement.

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 1, 2024
@AzureAaron AzureAaron merged commit 561beaf into SkyblockerMod:master Jan 1, 2024
@AzureAaron AzureAaron deleted the transparent-skin-layers-2 branch January 1, 2024 07:53
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly render transparency on player heads
2 participants