Skip to content

Add sync when clearing matchState #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add sync when clearing matchState #471

merged 1 commit into from
Jan 11, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

Fix some weird race condition where matchState and secretWaypoints get cleared after the isMatched() check and before secretWaypoint.values() call in Room#render.

@kevinthegreat1 kevinthegreat1 added wip This PR is a work in progress bug Something isn't working labels Jan 1, 2024
@AzureAaron AzureAaron added the merge me please Pull requests that are ready to merge label Jan 3, 2024
@AzureAaron AzureAaron added this to the 1.17 milestone Jan 10, 2024
@kevinthegreat1 kevinthegreat1 merged commit ce5f472 into SkyblockerMod:master Jan 11, 2024
@kevinthegreat1 kevinthegreat1 deleted the dungeon-secrets-sync-fix branch January 11, 2024 03:54
@AzureAaron AzureAaron removed merge me please Pull requests that are ready to merge wip This PR is a work in progress labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinthegreat1 @AzureAaron