Skip to content

Conversation

Kaluub
Copy link
Contributor

@Kaluub Kaluub commented Jan 15, 2024

Hello, I have 2 fixes for dungeons, I believe they were reported in Discord as well.

  1. Allow dropping protected items if in dungeons.
  2. Fix Livid colour text not being replaced.

@AzureAaron
Copy link
Collaborator

Not being able to drop protected items in dungeons is not a bug and is what’s intended.

@Kaluub
Copy link
Contributor Author

Kaluub commented Jan 15, 2024

How come it's intended? This prevents you from using your class abilities with (for example) your main weapon. The way I made this fix doesn't allow you to drop protected items from your inventory, only the currently held item, that event is cancelled by Hypixel for your abilities to work

@LegendaryLilac
Copy link
Contributor

i think the current mechanic is great, but there should be an option to have it turn off all slot locks when in dungeons

@AzureAaron
Copy link
Collaborator

How come it's intended? This prevents you from using your class abilities with (for example) your main weapon. The way I made this fix doesn't allow you to drop protected items from your inventory, only the currently held item, that event is cancelled by Hypixel for your abilities to work

It’s not meant to provide any exceptions for any circumstances. Personally I wouldn’t want to drop my 4B claymore at all anywhere dungeons included.

If you want to add this then it must be behind an option which is disabled by default.

@LegendaryLilac
Copy link
Contributor

you cant actuazlly drop items in dungeons, pressing q will instead use your ultimate

@alexytomi
Copy link

alexytomi commented Jan 15, 2024

you cant actuazlly drop items in dungeons, pressing q will instead use your ultimate

You can drop items in dungeons. You just have to do it through the inventory GUI. This doesn't trigger the ultimate

Instead, I think making Q move your main hand into the map and dropping it would be a better solution. Maybe have two or three button presses (one to swap to map slot and one to drop since the dungeon map isn't protected and a third to return to your original item that you were holding) to comply with Hypixel rules better? Or not but I don't think that's a good idea

@LegendaryLilac
Copy link
Contributor

the mod cant stop you from dropping from inventory tho

@alexytomi
Copy link

alexytomi commented Jan 15, 2024

the mod cant stop you from dropping from inventory tho

It absolutely does? It sometimes even stops me from putting my weapons it one of my bags because of it.

@Kaluub
Copy link
Contributor Author

Kaluub commented Jan 15, 2024

How come it's intended? This prevents you from using your class abilities with (for example) your main weapon. The way I made this fix doesn't allow you to drop protected items from your inventory, only the currently held item, that event is cancelled by Hypixel for your abilities to work

It’s not meant to provide any exceptions for any circumstances. Personally I wouldn’t want to drop my 4B claymore at all anywhere dungeons included.

If you want to add this then it must be behind an option which is disabled by default.

Okay, I understand. I can add the option in a bit.

the mod cant stop you from dropping from inventory tho

It does, although it is a different event than the one to drop the currently held item.

@kevinthegreat1
Copy link
Collaborator

The livid color part looks good.

@AzureAaron AzureAaron added the changes requested This PR need changes label Jan 16, 2024
@Kaluub
Copy link
Contributor Author

Kaluub commented Jan 18, 2024

If you want to add this then it must be behind an option which is disabled by default.

Done now.

@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jan 18, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, didn't test tho.

@kevinthegreat1 kevinthegreat1 added tester needed This is used for a Discord webhook to create a thread and notify the tester. and removed reviews needed This PR needs reviews labels Jan 19, 2024
@kevinthegreat1 kevinthegreat1 added this to the 1.17 milestone Jan 19, 2024
AzureAaron
AzureAaron previously approved these changes Jan 19, 2024
@AzureAaron AzureAaron added the merge me please Pull requests that are ready to merge label Jan 19, 2024
@AzureAaron AzureAaron linked an issue Jan 19, 2024 that may be closed by this pull request
@kevinthegreat1 kevinthegreat1 added new feature This issue or PR is a new feature and removed tester needed This is used for a Discord webhook to create a thread and notify the tester. labels Jan 20, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Jan 20, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop protected items in the entrance, is that desirable?

@kevinthegreat1 kevinthegreat1 added the bug Something isn't working label Jan 20, 2024
@kevinthegreat1 kevinthegreat1 dismissed stale reviews from AzureAaron and themself via fb602fa January 20, 2024 20:33
@kevinthegreat1 kevinthegreat1 merged commit fa4063d into SkyblockerMod:master Jan 20, 2024
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send Livid color incorrectly ("[color]" replaced with nothing)
5 participants