-
-
Notifications
You must be signed in to change notification settings - Fork 141
Dungeons improvements. #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix Livid colour text.
|
Not being able to drop protected items in dungeons is not a bug and is what’s intended. |
|
How come it's intended? This prevents you from using your class abilities with (for example) your main weapon. The way I made this fix doesn't allow you to drop protected items from your inventory, only the currently held item, that event is cancelled by Hypixel for your abilities to work |
|
i think the current mechanic is great, but there should be an option to have it turn off all slot locks when in dungeons |
It’s not meant to provide any exceptions for any circumstances. Personally I wouldn’t want to drop my 4B claymore at all anywhere dungeons included. If you want to add this then it must be behind an option which is disabled by default. |
|
you cant actuazlly drop items in dungeons, pressing q will instead use your ultimate |
You can drop items in dungeons. You just have to do it through the inventory GUI. This doesn't trigger the ultimate Instead, I think making Q move your main hand into the map and dropping it would be a better solution. Maybe have two or three button presses (one to swap to map slot and one to drop since the dungeon map isn't protected and a third to return to your original item that you were holding) to comply with Hypixel rules better? Or not but I don't think that's a good idea |
|
the mod cant stop you from dropping from inventory tho |
It absolutely does? It sometimes even stops me from putting my weapons it one of my bags because of it. |
Okay, I understand. I can add the option in a bit.
It does, although it is a different event than the one to drop the currently held item. |
|
The livid color part looks good. |
Done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, didn't test tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop protected items in the entrance, is that desirable?
fb602fa
Hello, I have 2 fixes for dungeons, I believe they were reported in Discord as well.