Add dungeon score calculation on client-side #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
requested changes
Jan 18, 2024
AzureAaron
added
changes requested
kevinthegreat1
added
reviews needed
Closed
kevinthegreat1
requested changes
Jan 19, 2024
src/main/java/de/hysky/skyblocker/mixin/ClientPlayNetworkHandlerMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/categories/DungeonsCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/DungeonScoreHUD.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/DungeonScore.java
Outdated
Show resolved
Hide resolved
kevinthegreat1
added
changes requested
|
I'm not very sure about the mimic filter, it would be nice if someone could take a look at it |
AzureAaron
previously approved these changes
Jan 20, 2024
AzureAaron
added
reviews needed
kevinthegreat1
requested changes
Jan 20, 2024
src/main/java/de/hysky/skyblocker/config/categories/DungeonsCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/filters/MimicFilter.java
Outdated
Show resolved
Hide resolved
|
Other than that, the score works great by the way! |
kevinthegreat1
added
new feature
kevinthegreat1
previously approved these changes
Jan 20, 2024
kevinthegreat1
added
merge me please
AzureAaron
previously approved these changes
Jan 20, 2024
This can happen if the player leaves the dungeon and rejoins while score is above 300, then fall below 300 from player deaths etc.
…micKilled boolean
…en borders Cleaned up the formatScore method to make sure all scores and letter rankings are equally wide, thereby making the text not move as score changes or go off screen borders when the location is set on a narrower score and a wider score is to be displayed.
There was a lingering ] that broke the whole mimic thing, and I spent 2 hours trying to figure out why...
Emirlol
dismissed stale reviews from AzureAaron and kevinthegreat1
via
1b6eddc
kevinthegreat1
approved these changes
Jan 21, 2024
AzureAaron
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The score shown in the scoreboard is updated very late and is never equal to what score you would get if you went and completed the dungeon at that moment. That goes against its purpose and makes it harder to judge when the score is enough for S or S+. This PR is for calculating score client-side with the info gathered from various places, allowing the player to see when the score is enough.
I'm mostly confident in the calculation's accuracy, but I'm not very sure if I've handled mimics right so do let me know if you see any mistakes or any alternative ways to do it.
I've also added score to the HUD with customizable location & size, but it's a bit messy as I simply patched the dungeon map config with the relevant things. It could be improved further, especially if there are plans to add more HUD elements.
(sorry for creating re-creating the same pull request as I'm a bit of a newb in the matters of git. I had to change the branch)