Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessories Helper #613

Merged
merged 6 commits into from Apr 4, 2024
Merged

Accessories Helper #613

merged 6 commits into from Apr 4, 2024

Conversation

AzureAaron
Copy link
Collaborator

No description provided.

@AzureAaron AzureAaron added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Mar 24, 2024
kevinthegreat1
kevinthegreat1 reviewed Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly looks good but I think it would be helpful to show what tier the accessory is in addition to the current information:

Tier: 4/5
✦ Upgrade

src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/AccessoriesHelper.java Outdated Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/AccessoriesHelper.java Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/AccessoriesHelper.java Outdated Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/AccessoriesHelper.java Show resolved Hide resolved
@kevinthegreat1 kevinthegreat1 added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Mar 27, 2024
@AzureAaron AzureAaron added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Mar 30, 2024
@AzureAaron
Copy link
Collaborator Author

Code mostly looks good but I think it would be helpful to show what tier the accessory is in addition to the current information:

Tier: 4/5
✦ Upgrade

I added this for the Downgrade, Upgradable and Upgrade states. It's like: Accessory: Upgradable (3/5). I didn't include the word Tier as it made the tooltip too long and I used ghost white because I felt like it went well with the existing colour scheme, if you have another colour idea feel free to suggest it.

@LifeIsAParadox LifeIsAParadox removed the reviews needed This PR needs reviews label Apr 3, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@LifeIsAParadox LifeIsAParadox added the merge me please Pull requests that are ready to merge label Apr 3, 2024
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 3, 2024
@LifeIsAParadox LifeIsAParadox added the merge me please Pull requests that are ready to merge label Apr 3, 2024
@kevinthegreat1 kevinthegreat1 merged commit bbf544b into SkyblockerMod:master Apr 4, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 4, 2024
@AzureAaron AzureAaron deleted the accessories-helper branch April 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AzureAaron @kevinthegreat1 @LifeIsAParadox