Skip to content

Conversation

AzureAaron
Copy link
Collaborator

Ever wanted an animated dye on your armour set but you either couldn't afford one or felt too restricted by having to choose between warden dye and lucky dye? Well then this new feature is for you!

You will be able to apply a custom animated dye to your armour by supplying two HEX colours from which the mod will create a gradient, you will also supply how many "samples" or colours are to be taken from this gradient (the progression is linear if you are into the math), whether you want the colours to cycle back and forth or not, and optionally a delay of how many ticks it'll take for the next colour to be progressed to.

Command Syntax: /skyblocker custom animatedDye [<hex1>] <hex2> <samples> <cycleBack> [<tickDelay>]
Ex: /skyblocker custom animatedDye 0061ff 60efff 10 true 4

I've also added a tip about this new feature as it's very cool.

@AzureAaron AzureAaron added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Apr 5, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but didn't test. Putting in bleeding edge for now.

Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  • If I read the code correctly it should show the color that is applied, yet it isn't showing, doesn't seem to work for static dye color either.

    image
  • an argument type for hex would be appreciated to show if you goofed it or nah. I didn't know if needed to put #FF0000 or 0xFF0000 or just FF0000

Apart it works great, my glacite armor is no glowwwyyyyyy 10/10

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Apr 8, 2024
@AzureAaron
Copy link
Collaborator Author

2 things:

  • If I read the code correctly it should show the color that is applied, yet it isn't showing, doesn't seem to work for static dye color either.
    image

  • an argument type for hex would be appreciated to show if you goofed it or nah. I didn't know if needed to put #FF0000 or 0xFF0000 or just FF0000

Apart it works great, my glacite armor is no glowwwyyyyyy 10/10

1: Not supported functionality.
2: None of the other hex accepting arguments have anything special.

@viciscat
Copy link
Collaborator

viciscat commented Apr 9, 2024

Not supported functionality.

sad but oh well

None of the other hex accepting arguments have anything special.

why noooootttt

anyways apart from those nitpicks it works so i'm just gonna approve

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed changes requested This PR need changes labels Apr 9, 2024
@AzureAaron AzureAaron merged commit b5775f7 into SkyblockerMod:master Apr 9, 2024
@AzureAaron AzureAaron deleted the animated-dye-colours branch April 9, 2024 19:58
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants