New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem compiling on Qt 5.5 #1

Closed
theinvisible opened this Issue May 12, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@theinvisible

theinvisible commented May 12, 2017

Hello,

it seems since your last updates it doesnt compile anymore on Qt 5.5

Error message:

/home/rene/DEV/qtcreator/openfortigui/qtinyaes/qtinyaes.cpp:175: Fehler: no matching function for call to ‘qToBigEndian(quint32, char*)’
     qToBigEndian((quint32)data.size(), dataSize.data());
                                                       ^
/home/rene/DEV/qtcreator/openfortigui/qtinyaes/qtinyaes.cpp:182: Fehler: no matching function for call to ‘qFromBigEndian(const char*)’
     auto dataLen = qFromBigEndian<quint32>(data.constData());
                                                            ^

Seems like on Qt 5.7 the function change its parameter type: http://doc.qt.io/qt-5/qtendian.html#qFromBigEndian

Qt 5.5 would be quite important becaue Ubuntu 16.04 uses this version as default.

Cheers
Rene

@Skycoder42 Skycoder42 self-assigned this May 13, 2017

@Skycoder42

This comment has been minimized.

Show comment
Hide comment
@Skycoder42

Skycoder42 May 13, 2017

Owner

Ah okay. I develop with latest Qt versions, and typically do not assure backward compability. This however is small enough to be adjusted.

Owner

Skycoder42 commented May 13, 2017

Ah okay. I develop with latest Qt versions, and typically do not assure backward compability. This however is small enough to be adjusted.

Skycoder42 added a commit that referenced this issue May 13, 2017

@Skycoder42

This comment has been minimized.

Show comment
Hide comment
@Skycoder42

Skycoder42 May 13, 2017

Owner

I updated the code based on the 5.6 documentation. I don't have a Qt Version that old, so please verify this fix does indeed work.

Owner

Skycoder42 commented May 13, 2017

I updated the code based on the 5.6 documentation. I don't have a Qt Version that old, so please verify this fix does indeed work.

@theinvisible

This comment has been minimized.

Show comment
Hide comment
@theinvisible

theinvisible May 16, 2017

Thanks, I will give it a try.

theinvisible commented May 16, 2017

Thanks, I will give it a try.

@theinvisible

This comment has been minimized.

Show comment
Hide comment
@theinvisible

theinvisible May 19, 2017

It is working now on 5.5, thanks.

But was there something changed in the implementation? I could not decrypt my existing AES-data, i had to encrypt it again with the new version.

theinvisible commented May 19, 2017

It is working now on 5.5, thanks.

But was there something changed in the implementation? I could not decrypt my existing AES-data, i had to encrypt it again with the new version.

@Skycoder42

This comment has been minimized.

Show comment
Hide comment
@Skycoder42

Skycoder42 May 19, 2017

Owner

I did change the encoding of binary data, because of a bug I found that did not take endianess into account. (Which means data could be incompatible between different devices). The en/decryption process still works the same, but the length of the contained data is encoded in a different way. But this is fixed now, the API (and the encryption process) will stay stable from now on.

If you need to decrypt data from the old format (and have no way around it), please create a different issue for this.

Owner

Skycoder42 commented May 19, 2017

I did change the encoding of binary data, because of a bug I found that did not take endianess into account. (Which means data could be incompatible between different devices). The en/decryption process still works the same, but the length of the contained data is encoded in a different way. But this is fixed now, the API (and the encryption process) will stay stable from now on.

If you need to decrypt data from the old format (and have no way around it), please create a different issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment