Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nd4j refactoring #101

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@RobAltena
Copy link
Collaborator

commented Aug 6, 2019

What changes were proposed in this pull request?

Cleanup of Nd4j. Get rid of the last TODO items and try to fix all compiler warnings.
This was the last build that did not break the tests/build. These changes are good to go.

How was this patch tested?

Java builds and passes the test like the current master.

cleanup
Signed-off-by: Robert Altena <Rob@Ra-ai.com>

@RobAltena RobAltena requested a review from AlexDBlack Aug 6, 2019

@AlexDBlack
Copy link

left a comment

LGTM other than one more possible cleanup (or do it in the next one).
Make sure this compiles (build full stack) then it can be merged...

RobAltena added 2 commits Aug 6, 2019
wip
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
wip
Signed-off-by: Robert Altena <Rob@Ra-ai.com>

@RobAltena RobAltena merged commit a438434 into SkymindIO:master Aug 6, 2019

@RobAltena RobAltena deleted the RobAltena:ra_nd4j branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.