Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove method with unused parameter. #102

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@RobAltena
Copy link
Collaborator

commented Aug 6, 2019

What changes were proposed in this pull request?

Nd4j.createBuffer(int[] data, long offset) was not using the offset parameter. And we already have a Nd4j.createBuffer(int[] data) method.

Removed an unused method using Nd4j.createBuffer(int[] data, long offset) and redirected the other ones to Nd4j.createBuffer(int[] data). Removed Nd4j.createBuffer(int[] data, long offset).

How was this patch tested?

Made sure both createBuffer methods returned the same Databuffer in a seperate test project. Made sure the tests passed when rerouting Nd4j.createBuffer(int[] data, long offset) to Nd4j.createBuffer(int[] data). Made sure the tests passed after redirecting all uses to Nd4j.createBuffer(int[] data).

remove method with unused parameter.
Signed-off-by: Robert Altena <Rob@Ra-ai.com>

@RobAltena RobAltena requested a review from AlexDBlack Aug 6, 2019

@AlexDBlack
Copy link

left a comment

👍

@RobAltena RobAltena merged commit ba1d1b1 into SkymindIO:master Aug 6, 2019

@RobAltena RobAltena deleted the RobAltena:ra_createBufferFix branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.