Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for eclipse#8087 #129

Merged
merged 8 commits into from Aug 20, 2019

Conversation

@RobAltena
Copy link
Collaborator

commented Aug 19, 2019

Remove INDArray trueScalar(DataType dataType, Number value); from the NDArrayFactory interface. Move and refactor to Nd4j.scalar(DataType dataType, Number value). This was the only place the function was used.

How was this patch tested?

Code was compiled & tested before the PR. Test results were similar after the PR (one less failed test).

RobAltena added 2 commits Aug 19, 2019
fix for eclipse#8087
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
remove commented code.
Signed-off-by: Robert Altena <Rob@Ra-ai.com>

@RobAltena RobAltena requested a review from AlexDBlack Aug 19, 2019

@AlexDBlack
Copy link

left a comment

I'm fine with moving the switch to ND4J and getting rid of the method

Let's also get rid of the BaseNDArrayFactory.trueScalar(Number) and Nd4j.trueScalar(Number) methods here?

RobAltena added 6 commits Aug 19, 2019
removing trueScalar.
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
wip
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
wip
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
wip
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
remove tueScalar.
Signed-off-by: Robert Altena <Rob@Ra-ai.com>
@RobAltena

This comment has been minimized.

@AlexDBlack
Copy link

left a comment

LGTM, as long as that other referenced issue is fixed in the next PR.

@RobAltena RobAltena merged commit 3831077 into SkymindIO:master Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.