Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff cleanup and fixes #150

Merged
merged 8 commits into from Aug 23, 2019

Conversation

@AlexDBlack
Copy link

commented Aug 22, 2019

Fixes: eclipse#8123 (removed offending library and rewrote SameDiff duplication/cloning methods)
Fixes: eclipse#8095
Fixes: eclipse#8117

Also:

  • SDVariable no longer extends DifferentialFunction
  • Small amount of cleanup
AlexDBlack added 5 commits Aug 22, 2019
Cleanup
Signed-off-by: AlexDBlack <blacka101@gmail.com>
SDVariable no longer extends DifferentialFunction
Signed-off-by: AlexDBlack <blacka101@gmail.com>
eclipse#8123 Remove cloning library to avoid 'illegal reflective acce…
…ss' warnings

Signed-off-by: AlexDBlack <blacka101@gmail.com>
eclipse#8095 Make Pooling3D abstract, fix flatbuffers serialization i…
…ssue

Signed-off-by: AlexDBlack <blacka101@gmail.com>
eclipse#8117 WordVectorSerializer deprecated method javadoc
Signed-off-by: AlexDBlack <blacka101@gmail.com>

@AlexDBlack AlexDBlack force-pushed the ab_20190822_fixes3 branch from 9b0636b to 945b439 Aug 23, 2019

Small fixes
Signed-off-by: AlexDBlack <blacka101@gmail.com>

@AlexDBlack AlexDBlack marked this pull request as ready for review Aug 23, 2019

AlexDBlack added 2 commits Aug 23, 2019
Final fixes
Signed-off-by: AlexDBlack <blacka101@gmail.com>
One more
Signed-off-by: AlexDBlack <blacka101@gmail.com>

@AlexDBlack AlexDBlack merged commit 80d3537 into master Aug 23, 2019

@AlexDBlack AlexDBlack deleted the ab_20190822_fixes3 branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.