Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dl4j LSTM and Dropout CuDNN fallback and options #152

Merged
merged 9 commits into from Aug 29, 2019

Conversation

@rnett
Copy link
Collaborator

commented Aug 23, 2019

Fixes eclipse#6732.

Also adds forward pass fallback for Conv layers.

rnett added 3 commits Aug 23, 2019
add fallback for Conv layer activation
Signed-off-by: Ryan Nett <rnett@skymind.io>
add fallback and config option for LSTM layers
Signed-off-by: Ryan Nett <rnett@skymind.io>
add fallback option and setting for dropout
Signed-off-by: Ryan Nett <rnett@skymind.io>

@rnett rnett requested a review from AlexDBlack Aug 23, 2019

@rnett rnett self-assigned this Aug 23, 2019

@rnett rnett requested review from AlexDBlack and removed request for AlexDBlack Aug 27, 2019

rnett added 6 commits Aug 27, 2019
fix comments and error messages
Signed-off-by: Ryan Nett <rnett@skymind.io>
move helper fail count to layer instance
Signed-off-by: Ryan Nett <rnett@skymind.io>
ignore helperCountFail for equals and json
Signed-off-by: Ryan Nett <rnett@skymind.io>
typo fix (MLK -> MKL)
Signed-off-by: Ryan Nett <rnett@skymind.io>
add MKLDNN to error messages
Signed-off-by: Ryan Nett <rnett@skymind.io>
add helperAllowFallback to builders, deprecate cudnnAllowFallback
Signed-off-by: Ryan Nett <rnett@skymind.io>

@rnett rnett requested a review from AlexDBlack Aug 28, 2019

@AlexDBlack
Copy link

left a comment

LGTM 👍

@AlexDBlack AlexDBlack merged commit f40bdcf into master Aug 29, 2019

@rnett rnett deleted the rn_lstm_fallback branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.