Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for concat op shape function (empty shapes) #167

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@AlexDBlack
Copy link

commented Aug 26, 2019

We shouldn't ignore empty arrays in the shape function.

For example: concat([1,0], [1,0], axis=0) -> [2,0] not [1,0]

Fix for concat op shape function (empty shapes)
Signed-off-by: AlexDBlack <blacka101@gmail.com>

@AlexDBlack AlexDBlack merged commit b417ca2 into master Aug 26, 2019

@AlexDBlack AlexDBlack deleted the ab_20190826_fixes2 branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.