Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDCNN cleanup pass #230

Merged
merged 7 commits into from Sep 4, 2019

Conversation

@rnett
Copy link
Collaborator

commented Sep 4, 2019

Clean up SDCNN javadocs and methods. Convolution ops should have 4 methods each, with and w/o name and w/ and w/o bias. @NonNull annotations were also added.

I also changed the builders for the convolution ops, the mixed SameDiff/INDArray builder prevented using the superclass SameDiff constructor and resulted in UUID op names. The builder is now just SameDiff, and there are INDArray constructors (Lombok doesn't support 2 builders).

Somewhat related, I'm going to add the backprop op for conv1d (the c++ op already exists), but I'm planing on holding off till after beta5.

rnett added 7 commits Sep 3, 2019
SDCNN cleanup
Signed-off-by: Ryan Nett <rnett@skymind.io>
NonNull annotations
Signed-off-by: Ryan Nett <rnett@skymind.io>
better javadoc, NonNull fix for sconv
Signed-off-by: Ryan Nett <rnett@skymind.io>
update builders to fix names
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
even more fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
fix for null bias
Signed-off-by: Ryan Nett <rnett@skymind.io>

@rnett rnett requested a review from AlexDBlack Sep 4, 2019

@rnett rnett self-assigned this Sep 4, 2019

@AlexDBlack
Copy link

left a comment

LGTM 👍

@rnett rnett merged commit e9454b8 into master Sep 4, 2019

@rnett rnett deleted the rn_sdcnn_cleanup branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.