Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff: Listener changes and training api update #99

Merged
merged 31 commits into from Aug 10, 2019

Conversation

@rnett
Copy link
Collaborator

commented Aug 5, 2019

New branch for #88.

I'm going to add a EarlyStoppingListener like DL4J's, other than that and final test running it should be ready for merge.

@rnett rnett requested a review from AlexDBlack Aug 5, 2019

@AlexDBlack
Copy link

left a comment

Almost there, mainly more polish and minor issues left, most of this is great.
One last pass, then this should be good to go.

Not sure how useful LatestActivationListener/ActivationRecord will be
let's cut that from this PR, it's big enough already
Spilling them to disk (or at least providing the option to do so) might be a more sensible option, but we can discuss and implement that separately

@rnett

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 7, 2019

I'll put off EarlyStopping (along with some kind of activation logging listener) till a later PR.

@rnett rnett requested a review from AlexDBlack Aug 7, 2019

rnett added 26 commits Jul 29, 2019
example api
Signed-off-by: Ryan Nett <rnett@skymind.io>
Lambda based evaluation
Signed-off-by: Ryan Nett <rnett@skymind.io>
lambda test
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
partial fixes, use get-variable listener framework, example Evaluatio…
…nListener

Signed-off-by: Ryan Nett <rnett@skymind.io>
javadoc fix and newInstance implementations
Signed-off-by: Ryan Nett <rnett@skymind.io>
output method overloads + listener args
Signed-off-by: Ryan Nett <rnett@skymind.io>
history and evaluation helpers
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
more fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
FitConfig and added getters and setters
Signed-off-by: Ryan Nett <rnett@skymind.io>
javadocs
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes, javadoc, added activations to history, added latest activation…
… listener

Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes, start of tests
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes and updates
Signed-off-by: Ryan Nett <rnett@skymind.io>
newInstance fixes, tests
Signed-off-by: Ryan Nett <rnett@skymind.io>
test fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
more operation config classes (evaluation, output, exec/single batch …
…output), fix custom eval tests

Signed-off-by: Ryan Nett <rnett@skymind.io>
merge fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
fix
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes, most old fit/evaluate/output methods use the builders
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
numerous fixes/cleanup
Signed-off-by: Ryan Nett <rnett@skymind.io>
fixes
Signed-off-by: Ryan Nett <rnett@skymind.io>
rnett and others added 5 commits Aug 7, 2019
javadoc
Signed-off-by: Ryan Nett <rnett@skymind.io>
Polish round 1
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Round 2
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Formatting + round 3
Signed-off-by: AlexDBlack <blacka101@gmail.com>
Round 4
Signed-off-by: AlexDBlack <blacka101@gmail.com>

@AlexDBlack AlexDBlack force-pushed the rn_new_sd_training branch from 608a2d7 to 653b2ff Aug 10, 2019

@AlexDBlack
Copy link

left a comment

I rebased on master and made some small tweaks/changes.
Rebase slightly messed up the commit history (I'm listed on old commits also), but not a big deal.

@AlexDBlack AlexDBlack merged commit 11bddb3 into master Aug 10, 2019

@AlexDBlack AlexDBlack deleted the rn_new_sd_training branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.