Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First emoji not showing correctly in Reading mode for headers #68

Closed
stecydube opened this issue Feb 17, 2022 · 8 comments
Closed

First emoji not showing correctly in Reading mode for headers #68

stecydube opened this issue Feb 17, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@stecydube
Copy link

Using theme (either regular or nord)

If you use a level 1 header like the following:

# 🍟 header

The emoji icon gets squished.

image

Go deeper for the heading level (like 5 or 6) and it disappears completely.

image

Also, spacing around it is not right when surrounded by spaces in some occasions:

Header 🍔miam ➡️ pizza

gives

image


Using Obsidian V0.13.23
ITS Theme, latest as of today but the problem existed before
On Windows 10

@stecydube stecydube added the bug Something isn't working label Feb 17, 2022
@SlRvb
Copy link
Owner

SlRvb commented Feb 18, 2022

This looks like you've got an emoji plugin installed 🤔

@stecydube
Copy link
Author

Dang, you're right it was caused by the Emoji Toolbar plugin. No longer present when I disabled it.

I'll let them know of the problem. Thank you 😎

@stecydube
Copy link
Author

Additional findings. There is clearly a combined effect between a specific style setting and the Emoji Toolbar plugin.

Editing mode

image

Reading mode

ITS theme: default

image

ITS theme with only setting the "Center heading with lines" enabled:

image

image

Works ok for the "Center headings" option though.

image

image

I just noticed that when "Center headings" is active, the underline does not get centered and that's even with the Emoji plugin disabled.

@SlRvb
Copy link
Owner

SlRvb commented Feb 18, 2022

Hmm very strange 🤔 I'll see what's going on.

@SlRvb
Copy link
Owner

SlRvb commented Feb 18, 2022

Ahh ok, I see the problem with the emoji toolbar, should be fixed now. f7a5643


As far as the regular center heading line not centering, that was intentional, but I guess I can see if I can also center those lines 🤔

Edit: Centered the lines now 👍🏽 b57fbf3

@stecydube
Copy link
Author

All fixed.
Found out that emoji don't show in back ticks when used inside a JS code block when the Emoji plugin is active. Not sure it's on your side though.

For example:

```js
console.log (`🍪`);
```

@SlRvb
Copy link
Owner

SlRvb commented Feb 18, 2022

I think that's an issue with the emoji toolbar 🤔 Seems to work fine on my vault that doesn't have the plugin installed

@stecydube
Copy link
Author

It definitely is an issue with the emoji toolbar, tried it with the default theme. Going to raise an issue with their team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants