Add Criteria::create()

Slamdunk · Jul 31, 2012 · 72f487a · 72f487a
1 parent 8cb70d8
commit 72f487a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/Doctrine/Common/Collections/Criteria.php b/lib/Doctrine/Common/Collections/Criteria.php
@@ -59,6 +59,16 @@ class Criteria
      */
     private $maxResults;
 
+    /**
+     * Creates an instance of the class.
+     *
+     * @return Criteria
+     */
+    public static function create()
+    {
+        return new static();
+    }
+
     /**
      * Construct new criteria
      *

diff --git a/tests/Doctrine/Tests/Common/Collections/CriteriaTest.php b/tests/Doctrine/Tests/Common/Collections/CriteriaTest.php
@@ -6,6 +6,13 @@
 
 class CriteriaTest extends \PHPUnit_Framework_TestCase
 {
+    public function testCreate()
+    {
+        $criteria = Criteria::create();
+
+        $this->assertInstanceOf("Doctrine\Common\Collections\Criteria", $criteria);
+    }
+
     public function testConstructor()
     {
         $expr     = new Comparison("field", "=", "value");
@@ -29,9 +36,8 @@ public function testWhere()
 
     public function testOrderings()
     {
-        $criteria = new Criteria();
-
-        $criteria->orderBy(array("foo" => "ASC"));
+        $criteria = Criteria::create()
+            ->orderBy(array("foo" => "ASC"));
 
         $this->assertEquals(array("foo" => "ASC"), $criteria->getOrderings());
     }