-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conduits appear to ignore canInsertItem and isItemValidForSlot #2068
Comments
|
I've rewritten the inserting code for 2.3, and while the old code needed rewriting, it called canInsertItem() (for ISidedInventory) and isItemValidForSlot() (for IInventory) just fine. Could it be that RotaryCraft only implements isItemValidForSlot() but is in fact an ISidedInventory? |
No. Furthermore, my |
|
Why the hell would you implement ISidedInventory if you don't put side restrictions on it? Rather than create fake accounts and try to get others to take the blame for your mistakes, how about you actually learn to code properly? :) |
|
You realize that's an abstract base class that can have its methods
|
|
Please don't even start, yoshiman22. We are trying to fix a fix a potential bug, not start a flamewar. |
|
And I misclicked. Oops. |
|
I'm a bit puzzled by this. However, as I rewrote the code for 2.3 I'm personally not inclined to spend much effort on it for 2.2.8. @1Matthias, would you be willing to test if the same thing happens with a current development version of Ender IO? e.g.: But please back up your world before trying. There are some changes that make downgrading again problematic. |
|
If there's a bug here, it's on Reika's end. That's how it works. :) @HenryLoenwind Don't bother trying to test or fix this, just say that Reika is not supported like the rest of us. |
|
I am unfortunately playing on a server, which means that I have a hard time updating at the moment. I will try however, and don't worry about my worlds. They are all tester, creative worlds. |
|
@yoshiman22 they are tring to fix a potential bug, so please if you arent gonna add anything even remotely useful for the testing of this bug, STOP commenting on the issue. |
|
After this point, I think we should stop commenting on, responding to, or mentioning yoshiman22. Feeding trolls is pointless and a waste of valuble time that could be spent fixing bugs, exploring for diamonds, attemping to hold the tides back with a spoon, etc. yoshiman22, I reccomend you just stop while you are ahead. |
|
@1Matthias Has the new EiO version rectified the issue? Also, @HenryLoenwind I would check |
|
Calling both would really be easy, I just didn't want to change the existing logic without major insight into such details. @tterrag1098 Any thoughts on this? I'd update #1897 if it's ok with you. |
|
Item conduits work fine with all other machines I have tried so far. |
Yes, that is automatic Extractor behavior.
Minimally to the point that you could probably not even profile it. |
|
When you have a larger item sorting system these methods can be called a lot of times per tick. @ReikaKalseki what does canInsertItem return for your slots? |
As said before, it bounces to Also, I know this to be a result of a change within EiO, as I do not see it in my instance with an older EiO. |
|
Also, just to put this out there, I have tested this with only RoC and EIO, nothing else. I even got rid of NEI for the sake of testing. |
|
@ReikaKalseki well - if you call isItemValidForSlot - why should there be any change when EIO would call that too? And which versions are working and which not? |
As I said before:
I am using 2.2.8.349 with no issues. OK, so it is apparently newer than 1M's version. |
|
By the way, it looks like this bug only occurs with conduits in In/Out mode, not insert mode. Just an odd side note. |
I only use insert, which might explain why I do not have it. |


I was using EnderIO conduits for an RotaryCraft extractor setup, and noticed that ore flakes went into the second slot, which should not happen normally. I had the conduits set to In/Out, and ore and flakes in the same chest. I am on MC 1.7.10 and EnderIO 1.7.10-2.2.8.344.
http://imgur.com/7knK5qR,oK1zu23
The text was updated successfully, but these errors were encountered: