Pinning the stable versions for ANTsPy and Photogrammetry #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending resolution of Slicer/Slicer#8844, also see QIICR/QuantitativeReporting#295
There was a problem hiding this comment.
Pull request overview
This PR pins stable versions for several Slicer extensions, primarily focusing on ANTsPy and Photogrammetry as mentioned in the description, while also updating SlicerMorph, QuantitativeReporting, and LanguagePacks configurations.
Key Changes:
- Pin ANTsPy, Photogrammetry, and SlicerMorph extensions to the
stable-5.10branch - Pin QuantitativeReporting to a specific commit hash
- Update LanguagePacks repository URL to point to SoniaPujolLab organization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SlicerANTsPy.json | Updated scm_revision from "main" to "stable-5.10" branch |
| Photogrammetry.json | Updated scm_revision from "master" to "stable-5.10" branch |
| SlicerMorph.json | Updated scm_revision from "master" to "stable-5.10" branch |
| QuantitativeReporting.json | Updated scm_revision from "master" to specific commit hash 2c0112785c9ba3af9be6a1f86d5ed7bb8b700705 |
| LanguagePacks.json | Updated scm_url from Slicer/SlicerLanguagePacks to SoniaPujolLab/SlicerLanguagePacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Looks like you have LanguagePacks and QuantitativeReporting in this PR too, but I suppose you didn't mean to. |
Contributor
Author
|
No, not sure where does come from? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the stable versions of these two extensions, Photogrammetry and ANTsPy, to branch "stable-5.10". Preview versions should continue to use the master/main. The other PR can be closed without merging (as it was trying to point out the development version to a different branch).
This is the one that needs to be merged.