Permalink
Commits on Oct 16, 2017
  1. STYLE: Re-order includes

    jcfr committed Oct 16, 2017
    From: Jean-Baptiste Vimort <jb.vimort@kitware.com>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26481 3bd1e089-480b-0410-8dfb-8563597acbee
  2. BUG: Improve warning message in vtkMRMLLayoutLogic::GetViewsFromAttri…

    jcfr committed Oct 16, 2017
    …butes
    
    This commit updates the warning message to be more explicit and facilitate
    debugging when developing custom view and view nodes in Slicer extensions.
    
    Before: Couldn't find node with SingletonTag: ...
     After: Found several nodes with a similar SingletonTag: ...
    
    From: Jean-Baptiste Vimort <jb.vimort@kitware.com>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26480 3bd1e089-480b-0410-8dfb-8563597acbee
  3. BUG: fix crush linux/Qt5 when show details segmentation editor effect

    pinter committed Oct 16, 2017
    (cherry picked from commit c2d85a8)
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26479 3bd1e089-480b-0410-8dfb-8563597acbee
  4. BUG: Fix MRMLDisplayableManager tests

    jcfr committed Oct 16, 2017
    This commit fixes a regression introduced in r26458 (COMP: Support VTK 8.1
    updating displayable manager to use vtkObjectFactory)
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26478 3bd1e089-480b-0410-8dfb-8563597acbee
  5. COMP: Update setuptools to avoid future update conflict related to se…

    jcfr committed Oct 16, 2017
    …tup.cfg
    
    This commit will avoid error like the following:
    
    ```
    error: Your local changes to the following files would be overwritten by checkout:
        setup.cfg
    Please, commit your changes or stash them before you can switch branches.
    Aborting
    ```
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26477 3bd1e089-480b-0410-8dfb-8563597acbee
  6. STYLE: Update setuptools external project removing obsolete lock mana…

    jcfr committed Oct 16, 2017
    …gement
    
    Following r26191 (COMP: Fix race condition when building python package.
    See #4394), removing of lock file became unnecessary because a different
    approach to support parallel build was implemented.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26476 3bd1e089-480b-0410-8dfb-8563597acbee
  7. STYLE: Rename SlicerMacroBuildQtModule to SlicerMacroBuildLoadableModule

    jcfr committed Oct 16, 2017
    This commit renames the CMake module file to be consistent with the
    provided macro.
    
    Deprecated macro "slicerMacroBuildQtModule" is maintained. After the
    following extensions are updated it will be removed:
    * Chest_Imaging_Platform
    * DiceComputation
    * exStone
    * FacetedVisualizer
    * FastGrowCutEffect
    * GelDosimetryAnalysis
    * GraphCutSegment
    * LightWeightRobotIGT
    * LongitudinalPETCT
    * MarginCalculator
    * MarkupsToModel
    * MatlabBridge
    * ModelClip
    * PerkTutor
    * PETTumorSegmentation
    * PortPlacement
    * RSSExtension
    * Sequences
    * SlicerIGT
    * SlicerPathology
    * Slicer-TrackerStabilizer
    * VirtualFractureReconstruction
    
    See https://issues.slicer.org/view.php?id=3332
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26475 3bd1e089-480b-0410-8dfb-8563597acbee
  8. STYLE: Update examples of extensions found in Extensions/Testing dire…

    jcfr committed Oct 16, 2017
    …ctory
    
    The examples were updated building the SlicerGenerateExtensionTemplates
    target.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26474 3bd1e089-480b-0410-8dfb-8563597acbee
  9. BUG: ExtensionWizard: Fix describe command

    jcfr committed Oct 16, 2017
    This commit fixes a regression introduced in r26461 (ENH: ExtensionWizard:
    Support layout with main CMakeLists in subdirectory)
    
    We cannot assume EXTENSION_NAME is always present in extension CMakeLists.txt.
    Instead we check if a given CMakeLists.txt is associated with an
    extension if it has the variable EXTENSION_HOMEPAGE.
    
    See https://www.slicer.org/wiki/Documentation/Nightly/Developers/Extensions/DescriptionFile
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26473 3bd1e089-480b-0410-8dfb-8563597acbee
  10. STYLE: Extension templates: Use correct macro to configure loadable m…

    jcfr committed Oct 16, 2017
    …odule
    
    See https://issues.slicer.org/view.php?id=4180
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26472 3bd1e089-480b-0410-8dfb-8563597acbee
  11. BUG: ExtensionWizard: Fix object has no attribute '_scriptPath' error

    jcfr committed Oct 16, 2017
    This commit fixes a regression introduced in r26461 (ENH: ExtensionWizard:
    Support layout with main CMakeLists in subdirectory)
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26471 3bd1e089-480b-0410-8dfb-8563597acbee
  12. ENH: Update python deps chardet, gitdb, setuptools, six, smmap and wheel

    jcfr committed Oct 16, 2017
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26470 3bd1e089-480b-0410-8dfb-8563597acbee
  13. COMP: Update vtkSlicerObjectFactory to support both c++98 and c++11

    jcfr committed Oct 16, 2017
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26469 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Oct 15, 2017
  1. COMP: DisplayableManager: Fix windows link error

    jcfr committed Oct 15, 2017
    This commit fixes "redefinition; different linkage" error reported on
    windows. The regression was introduced in r26458 (COMP: Support VTK 8.1
    updating displayable manager to use vtkObjectFactory)
    
    It implements the following changes:
    
    * It removes redundant include of ObjectFactory implementation
      from export header. Since it is already part of the translation unit,
      there is no need to add it again here.
    
    * It disables the export of object factory AutoInit_Construct and
      AutoInit_Destruct symbols. Since the factory is initialized in the
      same translation unit using "VTK_AUTOINIT", these symbols do not need
      to be exported.
    
    * It also fixes a typo in vtkMRMLDisplayableManagerExport.h changing
      VTKMRMLDisplayableManager_STATIC into MRMLDisplayableManager_STATIC.
    
    
    Content of the error:
    
    ```
    C:\S4R\Slicer-build\Libs\MRML\DisplayableManager\MRMLDisplayableManagerObjectFactory.cxx(106): error C2375: 'MRMLDisplayableManager_AutoInit_Construct' : redefinition; different linkage [C:\S4R\Slicer-build\Libs\MRML\DisplayableManager\MRMLDisplayableManager.vcxproj] [C:\S4R\Slicer.vcxproj]
    
                C:\S4\Libs\MRML\DisplayableManager\vtkMRMLDisplayableManagerExport.h(32) : see declaration of 'MRMLDisplayableManager_AutoInit_Construct'
    
    C:\S4R\Slicer-build\Libs\MRML\DisplayableManager\MRMLDisplayableManagerObjectFactory.cxx(121): error C2375: 'MRMLDisplayableManager_AutoInit_Destruct' : redefinition; different linkage [C:\S4R\Slicer-build\Libs\MRML\DisplayableManager\MRMLDisplayableManager.vcxproj] [C:\S4R\Slicer.vcxproj]
    
                C:\S4\Libs\MRML\DisplayableManager\vtkMRMLDisplayableManagerExport.h(32) : see declaration of 'MRMLDisplayableManager_AutoInit_Destruct'
    ```
    
    Reported-by: Andras Lasso <lasso@queensu.ca>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26468 3bd1e089-480b-0410-8dfb-8563597acbee
  2. COMP: Ensure extension can use SlicerConfigureDisplayableManagerObjec…

    jcfr committed Oct 15, 2017
    …tFactory
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26467 3bd1e089-480b-0410-8dfb-8563597acbee
  3. ENH: Update VTKv8

    jcfr committed Oct 15, 2017
    Slicer specific patches:
    
    ```
    $ git shortlog 78373e1..0f20760 --no-merges
    Max Smolens (1):
          COMP: WIP: Fix inconsistent-missing-override warning
    
    Steve Pieper (1):
          BUG: WIP: fix vtkPickingManager interaction with widgets
    ```
    
    List of VTK changes:
    
    ```
    $ git shortlog 92d2539..78373e1 --no-merges
    Allison Vacanti (4):
          Remove GLEW dependency from VTKM.
          Fix issues embedding VTK/VTKm into ParaView.
          Add version info to vtkm installation.
          Add benchmarking code for vtkmLevelOfDetail.
    
    Alvaro Sanchez (7):
          Fixed pickability tests.
          Changed map keys in vtkCompositeDataDisplayAttributes to be vtkDataObject*.
          Using flat-index attribute map for legacy OpenGL.
          Fixed OSPRay tests.
          Made pickCompositeData to be GL2 only.
          Bump WikiExamples.
          Fixes CompositeMapper2Pickability test on RogueResearch7.
    
    Andrew Bauer (6):
          Improvements for vtkNew for stl containers and comparison operations
          Fixing typo in vtkResampleWithDataSet documentation
          Fixing typo that causes compile error
          Changing vtkCellSizeFilter to output separate arrays for sizes
          Fixing Python wrapped use of vtkCellSizeFilter
          Adding simplified way to include the tab character for vtkDelimitedTextReader
    
    Aron Helser (3):
          Remove legacy code from v6.3
          Remove legacy 7.1 method from vtkBase64Utilities
          vtkTetra - fix compile warning on linux, style issue
    
    Bastien Jacquet (1):
          Predictable output for vtkTensorGlyph on non-symmetric tensors
    
    Ben Boeckel (6):
          Documentation/dev: mention that submodules need initialized
          develop.md: add a missing comma
          vtkInstantiator: deprecate
          github: add a PR template to point to gitlab
          metaio: undo a local patch
          ThirdParty/libproj4: undo an improper import
    
    Berk Geveci (4):
          Remove unnecessary code that holds reference.
          Replaced use of numpy.ones.
          Deprecated SMP filters, which are superseded by VTK-m filters.
          Deprecated SMP filters, which are superseded by VTK-m filters.
    
    Bill Lorensen (17):
          ENH: Bump Examples hash
          EN: Bump PoissonReconstructiom remote module
          ENH: Bump to get new baselibes and examples
          ENH: New baselines
          ENH: New baselines for new platform
          ENH: Tweaking Baselines
          ENH: Tweak baselines
          ENH: Baselines and warnings
          ENH: Tweak baselines
          ENH: Introducing VTKBookExamples
          Update WikiExamples.remote.cmake
          Update WikiExamples.remote.cmake
          Update WikiExamples.remote.cmake
          Update WikiExamples.remote.cmake
          ENH: Bump hash
          Update WikiExamples.remote.cmake
          Update WikiExamples.remote.cmake
    
    Boris Basic (2):
          Fix vktPointSet comment
          Fix a potential crash whith vtkRenderWindowInteractor::FindPokedRenderer
    
    Brad King (2):
          vtkMatplotlibMathTextUtilities: Fix crash in StringToPath
          ExternalData: Drop our module in favor of CMake's builtin copy
    
    Cory Quammen (5):
          Remove Infovis/Parallel module
          Remove dependency of vtkInfovisParallel
          Deprecate the vtkViewQt module
          Deprecate vtkGUISupportQtWebkit module
          Compile SimpleView example only if vtkViewsQt is available
    
    Dan Lipsa (29):
          Deprecate VTK_RENDERING_BACKEND=OpenGL
          Update python files for new module keywork.
          BUG: Use vtkRenderingLICOpenGL2 by default.
          BUG: Back buffer is not cleared if multiple renderers
          Zooming changed slightly for ImageTracerWidget
          Add test for PropPicker with two renderers.
          Deprecate Qt4 support.
          QVTKWidget2(qt4) and QVTKOpenGLWidget(qt5) cannot be wrapped
          No need for enclosing in between LEGACY_REMOVE
          Revert "Compile SimpleView example only if vtkViewsQt is available"
          Revert "Deprecate the vtkViewQt module"
          Update examples to Qt5
          Examples need vtkContextView.h
          Build qt examples only on qt5.
          Mark overriding functions with override.
          Replace left over VTK_OVERRIDE
          Issue Qt4 message only if not LEGACY_SILENT
          vtkViewsQt is used by SimpleView example.
          Add vtkLASReader.
          Add data and format files using VTK conventions.
          Read the Point Data Record format from the header.
          Delete unnecessary class vars and cleanup file.
          Save color, classification and intensity as scalar values.
          Test 2 las files
          Handle color in the test program.
          Remove comments.
          Wrap LAS reader.
          Additional baseline for LAS reader.
          Exclude vtkLASReader from build all.
    
    David E. DeMarle (21):
          Revert "Revert "Full revision and extension of support for hypertreegrid objects and filters""
          Revert "Revert "miscellaneous cleanup for merge readiness""
          fix member name also defined in parent class comp warn
          fix array index is used before limits check comp warn
          fix 'sign conversion in calc. even though can have neg' warning
          fix 'overides a destructor but is not marked override' warnings
          fix '32 bit shift implicity converted to 64' warning
          remove support for OpenGL1 from OSPRay and OptiX
          fixes for issues discovered by dashboards
          remove an unused argument
          prep to update xdmfs new files
          remove boost from vtk level of xdmf3
          make images small enough for all dashboard submitters
          Loosen the image comparison tolerance a bit.
          address compilation warnings
          fixup pointer usage in ospray tests
          Use nullptr throughout now that we are in the c++11 era.
          Correct the recent NULL replacement for windows compiler.
          Prevent crash when no material library available.
          fix a crash when showing an empty scene
          revert XDMF3 machinery to just before boost removal
    
    David Gobbi (7):
          Force wrappers to ignore C99/C++11 _Pragma operator
          Remove use of obsolete Python dl module
          Update the vtkDICOM remote module to 0.8.6.
          Use memcpy for pixel copies in vtkImageReslice.
          Fix comment-to-string wrapping error
          Suppress "decimal digit terminates octal escape sequence"
          Fix tabs and utf-8 quotes in source code
    
    David Thompson (17):
          Add per-block pickability to some OpenGL2 mappers.
          Fix virtual override warnings.
          Fix used-before-initialized warnings.
          Fix valgrind defect (uninitialized value).
          Fix header test; eliminate `VTK_DELETE_FUNCTION`.
          Fix cppcheck warnings.
          Install a testing header.
          Fix mis-capitalization of filename.
          More Linux fixes.
          Install header that implements test conditionals.
          Tests not picking up alternate baselines...
          Reset clipping range, hoping this fixes failing test.
          Implement 21-point wedge; fix others.
          Fix face normals for Lagrange tetrahedra.
          Fix face comparison in unstructured grid geometry filter.
          Fix an array with the wrong length.
          Fix some dashboard issues.
    
    Jakub Benda (1):
          Some initializations of LabelType in vtkFoamEntryValue.
    
    Jon Haitz Legarreta Gorroño (1):
          DOC: Fix Announcing section typo in release.md file.
    
    KWIML Upstream (1):
          KWIML 2017-09-21 (7db8b884)
    
    Ken Martin (18):
          update the implicit plane widget/rep to handle vr
          textmapper3d was recomputing the texture map too often
          new ivar in superclass makes local ivar redundent
          fix header test for OpenVR and minor cleanup
          fix compiler type warnings
          rev wiki examples  remote module to get more fixes
          rev wiki examples to fix more  warnings from buildbots
          remove a couple deprectaed modules from the all group
          fix a unused var warning
          mark ImmediateModeRendering as deprecated
          classes appear to have been deprecated for at least 5 years
          fix issue with matplotlib comparing local vars as if they were pointers
          add ability for the applicaiton to control vsync swapping
          manually convert more NULL to nullptr
          added swap control support for x windows
          replace VTK_SUCCESS which is not defined with 0
          fix some warnings that eeloo found
          try to fix compiler warning on eeloo
    
    Kitware Robot (2):
          Replace VTK_OVERRIDE with override.
          Replace VTK_DELETE_FUNCTION with =delete.
    
    Louis Amore (4):
          Add vtkXMLPTableWriter & vtkXMLPTableReader
          Regroup XMLPTableReader & XMLPDataReader common features
          Regroup XMLPTableWriter & XMLPDataWriter common features
          Add vtkXMLDataObjectWriter
    
    Lucas Gandel (2):
          Add opacity support for DiscretizableColorTransferFunction
          ENH: Remove MapScalars() implementation
    
    Marcelo Duarte Trevisani (2):
          Update Numpy support to accept non contiguous array
          Add: numpy_to_vtk keeps the numpy reference in memory
    
    Mathieu Westphal (5):
          Correcting Reflection Filter so all vectors can be reflected
          Add vtkXMLTableWriter and vtkXMLTableReader
          Fix OpenTurns include so PythonWrapping can work with OpenTurns module
          Generalising ColumnArray Selection
          Correct vtkAbstractContextItem methods signtures to use vtkIdType
    
    MetaIO Upstream (1):
          metaio 2017-09-28 (cad89e7b)
    
    Philippe P. Pébaÿ (4):
          Resolved a number of warnings and test failures of nightly buils
          Added a test for the HTG axis cut in 3d in ternary case
          Resolve compiler warning
          Increased test threshold to resolve a test defect
    
    Philippe Pébaÿ (1):
          Attempt to fix a Valgrind error detected on Ubuntu platform
    
    Proj Upstream (1):
          libproj4 2017-09-19 (c1dab0df)
    
    Robert Maynard (10):
          Export: VTK-m module is now exported into the VTKConfig.cmake
          Correct some conversion warnings in vtkm converters.
          Correct vtkmConnectivityExec export warnings under gcc-5
          Correct warnings found inside the vtkm module by dashboards.
          Move the vtk-m submodule forward to get fixes for dashboard warnings
          vtkmlib now consistently uses nullptr.
          vtkmContour respects the ComputeScalar variable
          vtkmlib now installs files into a subdirectory only.
          VTK-m now is properly parsed by the wrap hierarchy when kits are enabled.
          AcceleratorsVtkm now properly compiles when cuda or tbb are enabled.
    
    Sankhesh Jhaveri (4):
          Obsolete deprecated code in Common/Core
          Obsolete deprecated code in Common/DataModel
          Obsolete deprecated code in Common/ExecutionModel
          Obsolete deprecated code in Common/Math
    
    Sean McBride (5):
          Cleanup of vtkMultiThreader, notably removed ancient HP & SGI options
          Fixed -Wnull-pointer-arithmetic warning
          Removed a newline that stopped whole string from appearing in ccmake
          Improved performance of vtkLookupTable a bit
          Remove workarounds for old MS compilers
    
    Shawn Waldon (6):
          Port the source tarball script from ParaView to handle submodules
          Fix the source tarball script to make the large data archive
          Move .gitattributes files so they will not be globbed as data
          Fix segfault in vtkPointLocator when input has no points
          Skip point location when no input points to avoid error message
          Add updated baselines for eeloo
    
    Sujin Philip (1):
          Update VTK-m
    
    T.J. Corona (8):
          Add Lagrange polynomial higher-order cells to VTK.
          vtkPolygon: Add unbiased ear cut and bounded triangulate methods.
          vtkDelaunay2D: triangulate polygon with BoundedTriangulate()
          vtkIntersectionPolyDataFilter: use vtkPolygon::BoundedTriangulate
          vtkBooleanOperationPolyDataFilter: exit with failure if intersection fails
          TestPolygonBoundedTriangulate: fix memory overrun.
          vtkPolygon: for large polygons, dynamically allocate area array.
          LagrangeGeometricOperations: add baseline image.
    
    Tim Thirion (3):
          Migrate VTKViewer from its own repo to Examples/iOS
          Add README for VTKViewer
          Update VTKViewer for Xcode 9 & iOS 11
    
    Tobias Michael Post (2):
          Adding support for LAB/CIEDE2000 color interpolation.
          Fixes & cleanups to vtkCIEDE2000.
    
    Utkarsh Ayachit (10):
          Use `VTK_LEGACY` to flag legacy API.
          Put out a CMake warning for `OpenGL` backend.
          Update test to test VTK_CTF_LAB_CIEDE2000.
          Remove Qt 4 support.
          Remove unsupported Motif examples.
          Renable charts example and update them to use Qt5.
          Cleanup vtkSynchronizedRenderers & FXAA.
          Deprecate `vtkGlyph3DMapper::NestedDisplayLists`.
          Fix potential overflow.
          vtkGenericEdgeTable: Fix potentially uninitialized warning.
    
    Will Schroeder (2):
          Reenabled signed distance test
          Obsoleted class no data no tests
    
    XDMF Upstream (3):
          xdmf3 2017-09-22 (f4ab41d5)
          xdmf3 2017-09-22 (63c88e6e)
          xdmf3 2017-10-12 (4fb8185c)
    
    luzpaz (1):
          Misc. doxy and comment typo fixes
    ```
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26466 3bd1e089-480b-0410-8dfb-8563597acbee
  4. COMP: Update EMSegment to fix Qt5/VTK8 support

    jcfr committed Oct 15, 2017
    This commit updates qSlicerEMSegmentGraphWidget to support VTK 8.1
    by using QVTKOpenGLWidget instead of QVTKWidget.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26465 3bd1e089-480b-0410-8dfb-8563597acbee
  5. COMP: Update qSlicerWidgetTest2 to support Qt5/VTK8 by using QVTKOpen…

    jcfr committed Oct 15, 2017
    …GLWidget
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26464 3bd1e089-480b-0410-8dfb-8563597acbee
  6. COMP: qMRMLWidgetsConfigure: Fix HAVE_STDINT_H' macro redefined warning

    jcfr committed Oct 15, 2017
    See https://issues.slicer.org/view.php?id=4430
    
    This commit fixes the following warning:
    
    ```
    In file included from /path/to/Slicer/Libs/MRML/Widgets/qMRMLChartView.h:21:0,
                     from /path/to/Slicer-build/Slicer-build/Libs/MRML/Widgets/generated_cpp/org_slicer_libs_qMRMLWidgets/org_slicer_libs_qMRMLWidgets.h:11,
                     from /path/to/Slicer-build/Slicer-build/Libs/MRML/Widgets/generated_cpp/org_slicer_libs_qMRMLWidgets/org_slicer_libs_qMRMLWidgets_init.cpp:18:
    /path/to/Slicer-build/Slicer-build/Libs/MRML/Widgets/qMRMLWidgetsConfigure.h:24:0: warning: "HAVE_STDINT_H" redefined
     #define HAVE_STDINT_H
     ^
    In file included from /path/to/Slicer-build/python-install/include/python2.7/Python.h:8:0,
                     from /path/to/Slicer-build/CTK-build/CMakeExternals/Install/include/PythonQt/PythonQtPythonInclude.h:90,
                     from /path/to/Slicer-build/CTK-build/CMakeExternals/Install/include/PythonQt/PythonQtUtils.h:45,
                     from /path/to/Slicer-build/CTK-build/CMakeExternals/Install/include/PythonQt/PythonQt.h:45,
                     from /path/to/Slicer-build/Slicer-build/Libs/MRML/Widgets/generated_cpp/org_slicer_libs_qMRMLWidgets/org_slicer_libs_qMRMLWidgets_init.cpp:6:
    /path/to/Slicer-build/python-install/include/python2.7/pyconfig.h:909:0: note: this is the location of the previous definition
     #define HAVE_STDINT_H 1
     ^
    ```
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26463 3bd1e089-480b-0410-8dfb-8563597acbee
  7. ENH: ExtensionWizard: Support extension without project in toplevel C…

    jcfr committed Oct 15, 2017
    …MakeLists
    
    This allows updates of ExtensionIndex for extension like SegmentationAidedRegistration
    that do not define the project in the top-level CMakeLists.txt
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26462 3bd1e089-480b-0410-8dfb-8563597acbee
  8. ENH: ExtensionWizard: Support layout with main CMakeLists in subdirec…

    jcfr committed Oct 15, 2017
    …tory
    
    This allows to contribute description file update for the CarreraSlice
    extension.
    
    In that particular case, the top-level CMakeLists.txt doesn't contain
    all variables of the form EXTENSION_*, instead they are found in
    src/CMakeLists.txt.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26461 3bd1e089-480b-0410-8dfb-8563597acbee
  9. COMP: Ensure LibArchive external dependencies are effectively disabled

    jcfr committed Oct 15, 2017
    The use of "CMAKE_DISABLE_FIND_PACKAGE_" was needed in older version
    of LibArchive that didn't have the options.
    
    Co-authored-by: Dzenan Zukic <dzenan.zukic@kitware.com>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26460 3bd1e089-480b-0410-8dfb-8563597acbee
  10. ENH: Update GitPython

    jcfr committed Oct 15, 2017
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26459 3bd1e089-480b-0410-8dfb-8563597acbee
  11. COMP: Support VTK 8.1 updating displayable manager to use vtkObjectFa…

    jcfr committed Oct 15, 2017
    …ctory
    
    This commit introduces the CMake function "SlicerConfigureDisplayableManagerObjectFactory"
    used to configure VTK object factory allowing to instantiate displayable
    manager given the class name.
    
    It updates SlicerMacroBuildModuleLogic and qSlicerExport.h.in so that
    the generated object factories are properly initialized.
    
    It removes the use of vtkInstantiator that is deprecated following
    Kitware/VTK@8328eda merged on 2017-09-26.
    
    See https://gitlab.kitware.com/vtk/vtk/merge_requests/3324
    
    Co-authored-by: Jean-Baptiste Vimort <jb.vimort@kitware.com>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26458 3bd1e089-480b-0410-8dfb-8563597acbee
  12. ENH: Added qSlicerMarkupsPlaceWidget to designer plugin list

    jcfr committed Oct 15, 2017
    From: Thomas Vaughan <vaughan.thomas.a@gmail.com>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26457 3bd1e089-480b-0410-8dfb-8563597acbee
  13. ENH: Allow restricting Segment editor to certain views

    lassoan committed Oct 15, 2017
    Previously, Segment Editor allowed editing in all views, even where the Segmentation node was not displayed.
    Now editing is only allowed in view nodes where the Segmentation node is displayable - as specified by
    display nodes of the segmentation node (using AddViewNodeID/RemoveViewNodeID).
    
    It is now also possible to disable automatic display of the master volume node when switching between segmentation nodes
    or master volumes. This allows more refined control of segment editor when it is embedded into another module.
    Set autoShowMasterVolumeNode property of qMRMLSegmentEditorWidget to false to prevent automatic showing of master volume.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26456 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Oct 13, 2017
  1. COMP: vtkMRMLModelDisplayableManager: Fix unused variable warning

    jcfr committed Oct 13, 2017
    This commit fixes the following warning:
    
    ```
    /path/to/Slicer/Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx:867:10: warning: unused variable ‘updateModelNeeded’ [-Wunused-variable]
         bool updateModelNeeded = false;
              ^
    
    ```
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26455 3bd1e089-480b-0410-8dfb-8563597acbee
  2. COMP: Remove unneeded use of vtkInstantiatorNewMacro VTK based Slicer…

    jcfr committed Oct 13, 2017
    … factory
    
    Since the associated factory classes are not associated with the instantiator,
    this commit removes the associated function. This also faciliate the transition
    to VTK 8.1 were the instantiator support has been deprecated.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26454 3bd1e089-480b-0410-8dfb-8563597acbee
  3. STYLE: DisplayableManager: Update export header filename to be consis…

    jcfr committed Oct 13, 2017
    …tent
    
    This commit rename the file from vtkMRMLDisplayableManagerWin32Header.h to
    vtkMRMLDisplayableManagerExport.h.
    
    STYLE: Base and Libs: Update export header filename to be consistent
    
    This commit rename the export files from vtk.*Win32Header.h to
    vtk.*Export.h.
    
    The export filename between Slicer core libraries and Slicer modules
    are now consistent.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26453 3bd1e089-480b-0410-8dfb-8563597acbee
  4. BUG: Fix DICOM settings panel error with Qt5

    pinter committed Oct 13, 2017
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26452 3bd1e089-480b-0410-8dfb-8563597acbee
  5. STYLE: Fixed typo in variable name

    lassoan committed Oct 13, 2017
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26451 3bd1e089-480b-0410-8dfb-8563597acbee
  6. BUG: Fixed Segment Editor Scissors symmetric slice cut thickness setting

    lassoan committed Oct 13, 2017
    Segment Editor Scissors symmetric slice cut thickness setting was shown as if it was set in mm, while in reality it was the number of slices.
    
    Fixed it by computing the number of slices from the mm thickness value that the user selects.
    
    See https://discourse.slicer.org/t/symmetric-scissor-effect-issue/1210/3
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26450 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Oct 12, 2017
  1. BUG: Made Colors module table editor more robust

    lassoan committed Oct 12, 2017
    Initial value of scalar range was not always correct.
    It was possible to get into an infinite update loop.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26449 3bd1e089-480b-0410-8dfb-8563597acbee
  2. BUG: Fixed Colors module vtkMRMLColorTable node editing

    lassoan committed Oct 12, 2017
    Opacity value was incorrectly reset to 1 on each operation.
    Changes were not reflected on widget and GUI immediately do to lack of node modified event.
    Scalar range was incorrectly set to number of table values.
    It was not possible to adjust the values over a hardcoded range (-1024, 3071) - it is now configurable on the GUI.
    vtkMRMLColorTableNode::Copy created a shallow copy of the color table (while other color nodes and most other nodes create deep copy of internal VTK objects).
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26448 3bd1e089-480b-0410-8dfb-8563597acbee
  3. ENH: Added distance-based coloring option to model slice display

    lassoan committed Oct 12, 2017
    Distance encoded projection option shows a projection of the model on the slice, coloring the projection based on distance of the model from the slice plane.
    
    This visualization mode can show where a tool intersects the slice plane.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@26447 3bd1e089-480b-0410-8dfb-8563597acbee