Skip to content
Commits on Nov 16, 2012
  1. @jcfr

    ENH: Slicer 4.2.1

    Previous commit was incorrectly creating version 4.2.2
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21438 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 16, 2012
  2. @jcfr

    ENH: Slicer 4.2.2

    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21437 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 16, 2012
  3. @jcfr

    BUG: Move light box renderer manager proxy to abstract displayable ma…

    …nager
    
    Suggested by Steve Pieper
    Contributed by Jim Miller
    
    Moved the LightBoxRendererManagerProxy up to the superclass of the
    DisplayableManager hierarchy so that all (2D & 3D) displayable managers
    can interact with a lightbox.
    
    Note that light boxes are only currently supported on 2D viewers, so the
    proxy is only configured in qMRMLSliceView. CTK will need to be changed to
    put the LightBoxManager into ctkVTKAbstractView to make it accessible to
    both ctkVTKSliceView and ctkVTKRenderView. Then qMRMLThreeDView could also
    create and initialize a LightBoxManagerProxy and set it on its DisplayableManagers.
    Here, we would also want to move qMRMLSliceViewPrivate::vtkInternalLightBoxRendererManagerProxy
    class to a place where it could be used by both types of VTK widgets.
    
    The proxy can now be set on the DisplayableManagerGroup which
    broadcasts the proxy to all the DisplayableManagers in that group.
    
    See http://www.na-mic.org/Bug/view.php?id=2732
    
    Fixes #2732
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21436 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 16, 2012
  4. @finetjul @jcfr

    BUG: Update display when tensor display properies are modified

    When the properties node is modified, the event must be propagated so that
    the 3D and 2D displayable managers are notified and trigger a refresh.
    
    Closes #2374
    
    From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21435 3bd1e089-480b-0410-8dfb-8563597acbee
    finetjul committed with jcfr Nov 16, 2012
  5. @finetjul @jcfr

    BUG: Restore 2D slice glyph display

    When display nodes where added to a volume node,
    vtkMRMLVolumeGlyphSliceDisplayableManager was not notified so it couldn't
    observe the glyph diffusion tendor display node modify event.
    
    Issue #2374
    
    From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21434 3bd1e089-480b-0410-8dfb-8563597acbee
    finetjul committed with jcfr Nov 16, 2012
  6. @finetjul @jcfr

    BUG: Model displayable manager now supports any displayable node...

    ...that has display nodes with a non null output polydata.
    
    Issue #2374
    
    Conflicts:
    	Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx
    
    From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21433 3bd1e089-480b-0410-8dfb-8563597acbee
    finetjul committed with jcfr Nov 16, 2012
  7. @finetjul @jcfr

    BUG: Apply redesign to glyphable volume slice display nodes

    In r20910, model display nodes had a demand driven pipeline redesign.
    However, this redesign wasn't applied to glyphable volume slice display
    nodes.
    Issue #2374
    
    From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21432 3bd1e089-480b-0410-8dfb-8563597acbee
    finetjul committed with jcfr Nov 16, 2012
  8. @jcfr

    BUG: Add method to streamline loading of scalar volumes

    * Update DICOM scalar volume plugin to use the new method name.
    
    Adapted from topic proposed by Andriy Fedorov
    Credit: Andriy Fedorov, Julien Finet and Steve Pieper
    
    See http://na-mic.org/Bug/view.php?id=2748
    
    Fixes #2748
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21426 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 16, 2012
Commits on Nov 15, 2012
  1. @pieper @jcfr

    BUG: fix leaks on scene close - related to issue #2512

    Use vtkSmartPointers to rather than bare C pointers
    to manage lists of node references.  This avoids dangling
    pointers to already deleted nodes (and hence prevents
    crashes).
    
    Also STYLE: add at least some documentation to the header
    file describing what these methods are meant to do and
    how the data structures are managed.
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21424 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 15, 2012
  2. @pieper @jcfr

    STYLE: fix spelling error in variable name

    refrencingNode -> referencingNode
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21423 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 15, 2012
  3. @jcfr

    COMP: Fix build error occurring when disabling QtTesting

    See http://www.na-mic.org/Bug/view.php?id=2760
    
    Fixes #2760
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21420 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 15, 2012
  4. @jcfr

    BUG: Remove SWidget related code from Performance test

    This is a follow up of commit r21404
    
    See http://na-mic.org/Mantis/view.php?id=2735
    Fixes #2735
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21418 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 15, 2012
  5. @jcfr

    COMP: Fix windows build error using function prefixed with "_"

    See http://na-mic.org/Mantis/view.php?id=2535
    
    Fixes #2535
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21416 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 15, 2012
  6. @jcfr

    BUG: Prevent Slicer from hanging when restarting

    See CTK commit ad15090
    
    // ------------------------
    Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
    
    Ensure ctkFDHandler can be enabled/disabled multiple times
    
    To give the opportunity to the thread to exit the polling loop, the
    character "\n" is now written when disabling the handler.
    
    The pipe is also setup each time the thread is enabled. Additionally,
    the reading side of the redirection pipe is also closed when the thread is
    disabled.
    
    Tests have also been updated to enable/disable the handler multiple times
    in a row.
    // ------------------------
    
    See http://na-mic.org/Mantis/view.php?id=2535
    
    Fixes #2535
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21414 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 15, 2012
Commits on Nov 14, 2012
  1. @jcfr

    BUG: Remove extra initialization associated with "pkgIndex.tcl"

    Since the file "pkgIndex.tcl" has been removed with r21407, it shouldn't
    be imported.
    
    See http://www.na-mic.org/Bug/view.php?id=2735
    Fixes #2735
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21411 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 14, 2012
  2. @jcfr

    COMP: Remove SWidget tcl related code

    Keep the Slicer3Adapter.tcl around since it's still required by EMSegment
    
    Later on should also remove the slicer.sliceWidet* object since these
    ones can be accessed using the slicer.app.layoutManager() object.
    
    See http://na-mic.org/Mantis/view.php?id=2735
    Fixes #2735
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21409 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 14, 2012
  3. @jcfr

    STYLE: Provide more output to the user when missing parameter values …

    …issue #2517
    
    From: naucoin <naucoin@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21408 3bd1e089-480b-0410-8dfb-8563597acbee
    naucoin committed with jcfr Nov 14, 2012
  4. @pieper @jcfr

    ENH: clean up the prostate demo test to make it faster and more verbose

    To help with debugging the crash on exit issue #2512
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21405 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  5. @pieper @jcfr

    STYLE: avoid using Error macro on when behavior is not unexpected

    Since the null node message can be triggered during a scene load
    or scene view change, don't print messages to the error log unless
    specifically placed in debug mode.
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21404 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  6. @pieper @jcfr

    BUG: Clean up implementation of RSNA2012ProstateDemo

    Make this a proper self test module for easier testing.
    
    Work on progress for a fix to #2512
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21403 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  7. @pieper @jcfr

    ENH: speed up atlas tests by minimizing delay while printing status

    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21402 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  8. @pieper @jcfr

    STYLE: remove unused script (performance test cleanup)

    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21401 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  9. @pieper @jcfr

    BUG: use updated name for download of brain atlas

    fix for failing tests related to brain atlas in bug #2513
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21400 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  10. @pieper @jcfr

    ENH: add reloadable self test for DataProbe module

    Note: not yet fully implemented.  Requires additional refactoring
    of gui into logic, and reloadable code should replace widget in
    main gui (not just module gui).
    
    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21399 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  11. @pieper @jcfr

    ENH: show self test buttons in alphabetical order

    From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21398 3bd1e089-480b-0410-8dfb-8563597acbee
    pieper committed with jcfr Nov 14, 2012
  12. @jcfr

    BUG: Bump ITKv3 version.

    Get fixes to the SpatialObject vessel .tre file reader from hackathon
    with Jean-Christophe Fillion-Robin.
    
    From: mccormic <mccormic@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21397 3bd1e089-480b-0410-8dfb-8563597acbee
    mccormic committed with jcfr Nov 14, 2012
  13. @jcfr

    BUG: New brain atlas mrb (uploaded to Nightly dir), cleaned up storag…

    …e nodes.
    
    STYLE: give feedback about how many model hierarchies and scene views there are to test.
    
    Still to do: clean up the mrml file of extraneous view and camera nodes.
    
    Issue #2513
    
    From: naucoin <naucoin@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21396 3bd1e089-480b-0410-8dfb-8563597acbee
    naucoin committed with jcfr Nov 14, 2012
  14. @jcfr

    BUG: reduce warning messages when loading brain atlas and restoring s…

    …cenes.
    
    Only call update scene on nodes that are in the scene view.
    Use DisableModifiedEventOn instead of Start/EndModify when processing scene view child
    nodes since the scene view scene is not in importing state and this reduces
    responses to modified events.
    Added error checking and tweaked messages when reading model files.
    
    Issue #2513
    
    From: naucoin <naucoin@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21395 3bd1e089-480b-0410-8dfb-8563597acbee
    naucoin committed with jcfr Nov 14, 2012
  15. @jcfr

    COMP: Remove unused file "PlastimatchDVH.s4ext-disabled"

    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21394 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 14, 2012
  16. @jcfr

    ENH: Make inclusion of .hxx/.txx files consistent.

    A long oustanding inconsistentcy in ITKv4 has been made
    consistent.  This patch syncronizes all the code
    to use the consistent and preferred mechanisms.
    
    From: hjohnson <hjohnson@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21393 3bd1e089-480b-0410-8dfb-8563597acbee
    hjohnson committed with jcfr Nov 14, 2012
  17. @jcfr

    ENH: shorten the names of the loaded volumes to prevent resizing of t…

    …he module panel node selection widget
    
    From: fedorov <fedorov@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21392 3bd1e089-480b-0410-8dfb-8563597acbee
    fedorov committed with jcfr Nov 14, 2012
  18. @jcfr

    BUG: fix the issue when no multivolumes could be loaded correctly

    From: fedorov <fedorov@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21391 3bd1e089-480b-0410-8dfb-8563597acbee
    fedorov committed with jcfr Nov 14, 2012
  19. @jcfr

    BUG: Do not pass "--attach-process" when setting sys.argv

    It avoid some python script to complain about unknown argument.
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21390 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 14, 2012
  20. @jcfr

    COMP: Ensure application test written in python run serially

    Hopefully this will help prevent the factory from crashing
    when running the tests.
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21389 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 14, 2012
  21. @jcfr

    COMP: Add "vtkMRMLTransformableNodeReferenceSaveImportTest" to the li…

    …st of tests
    
    This is a follow-up of commit r21332
    
    See #2725
    
    From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>
    
    git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21388 3bd1e089-480b-0410-8dfb-8563597acbee
    jcfr committed Nov 14, 2012
Something went wrong with that request. Please try again.