Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sequences extension to Slicer core #4461

Closed
slicerbot opened this issue Mar 13, 2020 · 0 comments · Fixed by #4810, #4834, #4833, #4831 or #4830
Closed

Move Sequences extension to Slicer core #4461

slicerbot opened this issue Mar 13, 2020 · 0 comments · Fixed by #4810, #4834, #4833, #4831 or #4830
Assignees
Labels
type:enhancement New feature or request
Milestone

Comments

@slicerbot
Copy link
Collaborator

slicerbot commented Mar 13, 2020

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@lassoan lassoan self-assigned this Mar 26, 2020
@lassoan lassoan added status:in-progress Person who the issue is assigned to currently works on this type:enhancement New feature or request labels Apr 2, 2020
jcfr pushed a commit to lassoan/Slicer that referenced this issue Apr 16, 2020
Move latest master version of Sequences extension (https://github.com/SlicerRt/Sequences) to Slicer core.
This extension allows recording and replaying of sequences of almost any node types.

Merge Sequences and Sequence Browser modules to make all important sequence features
in one place. Some features, such as plotting may be moved out to separate modules in the future.

Design changes made along with the migration:

* PR Slicer#4830: Refactor MRML node API to support shallow and deep copy
* PR Slicer#4831: Update MRML node API to allow listing of node content modification events
* PR Slicer#4832: Ensure vtkCodedEntryTest1 and vtkOrientedGridTransformTest1 are executed.
* PR Slicer#4833: Refactor vtkArchive to support use from MRML Core classes.
* PR Slicer#4834: Update MRML scene API adding support for read/write of MRML bundle.

Note that Sequence file reader was moved to SlicerIGT. See SlicerIGT/SlicerIGT#196

Fixes Slicer#4461
jcfr pushed a commit to lassoan/Slicer that referenced this issue Apr 17, 2020
Move latest master version of Sequences extension (https://github.com/SlicerRt/Sequences) to Slicer core.
This extension allows recording and replaying of sequences of almost any node types.

Merge Sequences and Sequence Browser modules to make all important sequence features
in one place. Some features, such as plotting may be moved out to separate modules in the future.

Design changes made along with the migration:

* PR Slicer#4830: Refactor MRML node API to support shallow and deep copy
* PR Slicer#4831: Update MRML node API to allow listing of node content modification events
* PR Slicer#4832: Ensure vtkCodedEntryTest1 and vtkOrientedGridTransformTest1 are executed.
* PR Slicer#4833: Refactor vtkArchive to support use from MRML Core classes.
* PR Slicer#4834: Update MRML scene API adding support for read/write of MRML bundle.

Note that Sequence file reader was moved to SlicerIGT. See SlicerIGT/SlicerIGT#196

Fixes Slicer#4461
jcfr pushed a commit to lassoan/Slicer that referenced this issue Apr 17, 2020
Move latest master version of Sequences extension (https://github.com/SlicerRt/Sequences) to Slicer core.
This extension allows recording and replaying of sequences of almost any node types.

Merge Sequences and Sequence Browser modules to make all important sequence features
in one place. Some features, such as plotting may be moved out to separate modules in the future.

Modules and plugins added:
* Sequences (C++ loadable)
* CropVolumeSequence (python scripted): Crop and resample a volume
  sequence to reduce its size for faster rendering and processing
* DICOMVolumeSequencePlugin: Support export of sequence node
  that contains volumes to DICOM
* SampleData: CTPCardioSeq and CTCardioSeq

Design changes made along with the migration:

* PR Slicer#4830: Refactor MRML node API to support shallow and deep copy
* PR Slicer#4831: Update MRML node API to allow listing of node content modification events
* PR Slicer#4832: Ensure vtkCodedEntryTest1 and vtkOrientedGridTransformTest1 are executed.
* PR Slicer#4833: Refactor vtkArchive to support use from MRML Core classes.
* PR Slicer#4834: Update MRML scene API adding support for read/write of MRML bundle.

Update vtkMRMLNodeTest1:
* Disable test of display node reference
  by introducing DISPLAY_SCENE_NODE_REFERENCES define set to 0

Disabled SceneView tests (they will be fixed in follow-up commits):
* vtkMRMLSceneViewNodeImportSceneTest
* vtkMRMLSceneViewNodeEventsTest
* vtkMRMLSceneViewNodeRestoreSceneTest
* vtkMRMLSceneViewNodeStoreSceneTest
* AnnotationsTestingFiducialWithSceneViewRestore
* MarkupsSceneViewRestoreTestSimple
* MarkupsSceneViewRestoreTestManyLists
* AddStorableDataAfterSceneViewTest

Notes:
* Sequence file reader was moved to SlicerIGT. See SlicerIGT/SlicerIGT#196

Fixes Slicer#4461
jcfr added a commit that referenced this issue Apr 17, 2020
Move latest master version of Sequences extension (https://github.com/SlicerRt/Sequences) to Slicer core.
This extension allows recording and replaying of sequences of almost any node types.

Merge Sequences and Sequence Browser modules to make all important sequence features
in one place. Some features, such as plotting may be moved out to separate modules in the future.

Modules and plugins added:
* Sequences (C++ loadable)
* CropVolumeSequence (python scripted): Crop and resample a volume
  sequence to reduce its size for faster rendering and processing
* DICOMVolumeSequencePlugin: Support export of sequence node
  that contains volumes to DICOM
* SampleData: CTPCardioSeq and CTCardioSeq

Design changes made along with the migration:

* PR #4830: Refactor MRML node API to support shallow and deep copy
* PR #4831: Update MRML node API to allow listing of node content modification events
* PR #4832: Ensure vtkCodedEntryTest1 and vtkOrientedGridTransformTest1 are executed.
* PR #4833: Refactor vtkArchive to support use from MRML Core classes.
* PR #4834: Update MRML scene API adding support for read/write of MRML bundle.

Update vtkMRMLNodeTest1:
* Disable test of display node reference
  by introducing DISPLAY_SCENE_NODE_REFERENCES define set to 0

Disabled SceneView tests (they will be fixed in follow-up commits):
* vtkMRMLSceneViewNodeImportSceneTest
* vtkMRMLSceneViewNodeEventsTest
* vtkMRMLSceneViewNodeRestoreSceneTest
* vtkMRMLSceneViewNodeStoreSceneTest
* AnnotationsTestingFiducialWithSceneViewRestore
* MarkupsSceneViewRestoreTestSimple
* MarkupsSceneViewRestoreTestManyLists
* AddStorableDataAfterSceneViewTest

Notes:
* Sequence file reader was moved to SlicerIGT. See SlicerIGT/SlicerIGT#196

Fixes #4461

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
@lassoan lassoan removed the status:in-progress Person who the issue is assigned to currently works on this label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment