New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add vtkMRMLStorageNode CompressionParameter and presets #1038

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Sunderlandkyl
Copy link

Sunderlandkyl commented Nov 2, 2018

-Adds a framework for specifying different preset levels of compression in vtkMRMLStorageNode
-Changes in vtkStreamingVolumeCodec also allow codecs to specify their own presets
-Replaces previous CompressionLevel int

image

@pieper

This comment has been minimized.

Copy link
Member

pieper commented Nov 2, 2018

Generally this looks great to me (I didn't have a chance to test or read too carefully).

One thing that occurs to me is that the "Show options" checkbox persists during a Slicer session, but is reset on restart.

If we persist the state to settings, then users like Murat would be able to have easy access to these options for their large datasets (where picking a particular mode on a per-dataset level may save several minutes per save operation).

ENH: Add vtkMRMLStorageNode CompressionParameter and presets
-Adds a framework for specifying different preset levels of compression in vtkMRMLStorageNode
-Changes in vtkStreamingVolumeCodec also allow codecs to specify their own presets
-Replaces previous CompressionLevel int

@Sunderlandkyl Sunderlandkyl force-pushed the Sunderlandkyl:compression_parameter_preset branch from 79a92db to f874bb6 Nov 13, 2018

@Sunderlandkyl

This comment has been minimized.

Copy link
Author

Sunderlandkyl commented Nov 13, 2018

The checkbox should now persist between sessions.

@Sunderlandkyl

This comment has been minimized.

Copy link
Author

Sunderlandkyl commented Nov 13, 2018

@lassoan

This comment has been minimized.

Copy link
Contributor

lassoan commented Nov 14, 2018

Thank you! Merged - 900bc41.

I've changed some method names, so you may need to update extensions that use this.

@lassoan lassoan closed this Nov 14, 2018

@Sunderlandkyl Sunderlandkyl deleted the Sunderlandkyl:compression_parameter_preset branch Nov 14, 2018

@Sunderlandkyl Sunderlandkyl restored the Sunderlandkyl:compression_parameter_preset branch Nov 14, 2018

@Sunderlandkyl Sunderlandkyl deleted the Sunderlandkyl:compression_parameter_preset branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment