New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added option to load MRB files from Sample Data module #1065

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@smrolfe
Copy link

smrolfe commented Dec 19, 2018

In the Sample Data module, scene files (.mrb or .mrml) are not loaded into Slicer by default. This default could not be changed when registering a custom data set. Now a parameter has been added to specify if the files should be loaded for a custom data set.

@jcfr

jcfr approved these changes Dec 19, 2018

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Dec 19, 2018

Thanks @smrolfe 👍

The change makes sense.

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Dec 19, 2018

I will integrate the change and also update the docstring.

@smrolfe

This comment has been minimized.

Copy link

smrolfe commented Dec 19, 2018

Great! thanks @jcfr

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Dec 19, 2018

Closing. Fix integrated in r27666

@jcfr jcfr closed this Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment