Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upENH: Add scripted module template with Qt Designer GUI #1072
Conversation
lassoan
requested review from
pieper
and
jcfr
Jan 10, 2019
lassoan
force-pushed the
lassoan:scripted-module-with-qtdesigner
branch
from
71dd2b3
to
e913cb7
Jan 10, 2019
This comment has been minimized.
This comment has been minimized.
|
Looks great |
jcfr
approved these changes
Jan 10, 2019
lassoan
changed the title
ENH: Add scripted module template with Qt Designer GUI (WIP - do not merge yet)
ENH: Add scripted module template with Qt Designer GUI
Jan 10, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for the feedback, I've merged this. @jcfr if you could make designer.exe available in the install tree (with --designer option in the launcher) then it would be great. As is now, the "Edit UI" button only shows up if Slicer is launched from the build tree. |
lassoan
closed this
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
lassoan commentedJan 10, 2019
Added a scripted module template that creates module GUI from .ui file generated by Qt Designer.
Todo: