New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update level tracing effect on mouse wheel event #1073

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@vovythevov
Copy link
Contributor

vovythevov commented Jan 11, 2019

This allows the level tracing effect to be updated when the user scrolls
through the slices.

On the implementation:
Note that the method processViewNodeEvents is used instead of adding the
events with the MouseMoveEvent as the MouseMoveEvent eats the event
(abortEvent == True) which prevent the slice from scrolling.
If the MouseWheelForwardEvent and MouseWheelBackwardEvent are given their
own case (without abortEvent == True) weird interaction happen as the
effect preview is seemingly called before the slice has scrolled to the new
offset.

ENH: Update level tracing effect on mouse wheel event
This allows the level tracing effect to be updated when the user scrolls
through the slices.

On the implementation:
Note that the method processViewNodeEvents is used instead of adding the
events with the MouseMoveEvent as the MouseMoveEvent eats the event
(abortEvent == True) which prevent the slice from scrolling.
If the MouseWheelForwardEvent and MouseWheelBackwardEvent are given their
own case (without abortEvent == True) weird interaction happen as the
effect preview is seemingly called before the slice has scrolled to the new
offset.

@vovythevov vovythevov requested a review from lassoan Jan 11, 2019

@lassoan
Copy link
Contributor

lassoan left a comment

Thank you, it looks OK.

This effect is using the old editor design (it is 2D only and only works if slice view is aligned with volume axis), so it would need an overall design update.

@vovythevov

This comment has been minimized.

Copy link
Contributor Author

vovythevov commented Jan 11, 2019

Thanks for the review !
Intergrated in http://svn.slicer.org/Slicer4/trunk@27684

@vovythevov vovythevov closed this Jan 11, 2019

@ihnorton

This comment has been minimized.

Copy link
Member

ihnorton commented Jan 14, 2019

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment