Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix issues with DICOM browser widget #1200

Closed
wants to merge 1 commit into from

Conversation

@Sunderlandkyl
Copy link

commented Aug 20, 2019

Fix qSlicerDICOMModuleGenericTest failure

  • qSlicerDICOMModuleGenericTest is run without the main window, so layout manager does not not exist.
  • Now checks to make sure the layout manager exists before creating the connection

Fix issue where data is loaded and the widget closes, yet the layout remains the same

  • See https://issues.slicer.org/view.php?id=4705
  • Certain datasets invoke start/end batch processing
  • This caused an unnecessary update of the previous/current layout within the DICOM module
  • Solved by only changing the previous/current layout if it is different from the current layout

Allow the subject hierarchy tree to expand within the module layout

  • Remove the extra spacer from the module layout, allowing the tree widget to expand
BUG: Fix issues with DICOM browser widget
Fix qSlicerDICOMModuleGenericTest failure
* qSlicerDICOMModuleGenericTest is run without the main window, so layout manager does not not exist.
* Now checks to make sure the layout manager exists before creating the connection

Fix issue where data is loaded and the widget closes, yet the layout remains the same
* See https://issues.slicer.org/view.php?id=4705
* Certain datasets invoke start/end batch processing
* This caused an unnecessary update of the previous/current layout within the DICOM module
* Solved by only changing the previous/current layout if it is different from the current layout

Allow the subject hierarchy tree to expand within the module layout
* Remove the extra spacer from the module layout, allowing the tree widget to expand
@cpinter

This comment has been minimized.

Copy link

commented Aug 20, 2019

Looks good, thank you!

@jcfr

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Thanks for the fix 👍

Closing. Integrated in r28451

@jcfr jcfr closed this Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.