Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Make EditorEffects base classes available for extensions #1277

Open

Conversation

@lassoan
Copy link
Contributor

lassoan commented Dec 5, 2019

SlicerMacroBuildModuleQtLibrary macro does not add module include directories to CMake variables that are exposed to extensions. However, we need Segmentations/EditorEffects classes to be available for extensions to allow creating editor effects in C++.

See background in https://discourse.slicer.org/t/unable-to-include-qslicersegmentationseditoreffects-when-building-extension/9371/5

SlicerMacroBuildModuleQtLibrary macro does not add module include directories to CMake variables that are exposed to extensions.
However, we need Segmentations/EditorEffects classes to be available for extensions to allow creating editor effects in C++.
@lassoan lassoan requested a review from jcfr Dec 5, 2019
@lassoan

This comment has been minimized.

Copy link
Contributor Author

lassoan commented Dec 5, 2019

@jcfr is there any drawback of using SlicerMacroBuildModuleWidgets macro for exposing Segment Editor effects C++ base classes to extensions? Do you have any alternative suggestions? We used SlicerMacroBuildModuleQtLibrary before but that did not make these classes available for extensions.

@lassoan

This comment has been minimized.

Copy link
Contributor Author

lassoan commented Dec 6, 2019

@jcfr can you have a look? Just tell me if it's OK to use the macro like this. Thanks!

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Jan 7, 2020

I don't foresee any issues. That said, I suggest we introduce a new CMake function called SlicerMacroBuildModuleEditorEffect

And as discussed, a new module template should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.