New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3808 fiducial picking #179

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pieper
Member

pieper commented Sep 5, 2014

Note this branch is for testing and should not be merged as-is, but it can be built for testing if needed.

This version depends on changes in Slicer/VTK [1].

[1] pieper/VTK@Slicer:slicer-v6.2.0-7167ad1_2014-08-21_v2...3808-fiducial-picking

If all looks good, merge the VTK changes and then update SuperBuild/External_VTKv6.cmake to point to the right place before committing to slicer svn.

@pieper

This comment has been minimized.

Member

pieper commented Sep 5, 2014

Note: this has been merged as r23648.

The superbuild still points to pieper/VTK rather than Slicer/VTK until the correct branching is sorted out there, but this should be fine for a round of nightlies for final testing.

@pieper pieper closed this Sep 5, 2014

@jcfr

This comment has been minimized.

Member

jcfr commented Sep 6, 2014

@pieper Do you think this topic caused the test py_MarkupsInCompareViewersSelfTest to fail: http://slicer.cdash.org/testDetails.php?test=5704490&build=266935 ?

@pieper

This comment has been minimized.

Member

pieper commented Sep 6, 2014

Good thing the tests are running ; )

Fixed in: r23656

@jcfr

This comment has been minimized.

Member

jcfr commented Sep 6, 2014

Thanks for addressing the issue. 🎱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment