New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension buildsystem: sandbox all steps #768

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jcfr
Copy link
Member

jcfr commented Aug 10, 2017

This topic updates the extension build system so that a failure in any of the
extension download/configure/build/test/packaging steps do not cause the
entire build to fail.

See https://discourse.slicer.org/t/no-nightly-mac-binary-since-august-1/836/10?u=jcfr

Fixes #4247

The corresponding tests have also been updated to include an extension with source failing to be checked out. In that case, download error will be reported as configure error and the other extensions will still be built.

$ ctest -R "extension" 
Test project /home/jcfr/Projects/Slicer-2-build/Slicer-build
    Start  3: cmake_slicer_extension_description_spec_defaults_test
1/8 Test  #3: cmake_slicer_extension_description_spec_defaults_test ...............   Passed    0.00 sec
    Start  4: cmake_slicer_extension_metadata_set_defaults_test
2/8 Test  #4: cmake_slicer_extension_metadata_set_defaults_test ...................   Passed    0.00 sec
    Start  5: cmake_slicer_extract_extension_description_test
3/8 Test  #5: cmake_slicer_extract_extension_description_test .....................   Passed    0.01 sec
    Start  6: cmake_slicer_generate_extension_description_test
4/8 Test  #6: cmake_slicer_generate_extension_description_test ....................   Passed    0.01 sec
    Start  7: py_cmake_slicer_extensions_index_build_without_upload
5/8 Test  #7: py_cmake_slicer_extensions_index_build_without_upload ...............   Passed   34.09 sec
    Start  8: py_cmake_slicer_extensions_index_build_with_upload
6/8 Test  #8: py_cmake_slicer_extensions_index_build_with_upload ..................   Passed   35.14 sec
    Start  9: py_cmake_slicer_extensions_index_build_with_upload_using_ctest
7/8 Test  #9: py_cmake_slicer_extensions_index_build_with_upload_using_ctest ......   Passed   34.81 sec
    Start 10: py_cmake_slicer_extensions_index_build_without_upload_using_ctest
8/8 Test #10: py_cmake_slicer_extensions_index_build_without_upload_using_ctest ...   Passed   34.24 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
CMake    = 138.30 sec (8 tests)

Total Test time (real) = 138.35 sec

jcfr added some commits Aug 10, 2017

BUG: Extension build system: Sandbox download step and report downloa…
…d error

This commit updates the build system so that a failure in any of the
extension download/configure/build/test/packaging steps do not cause the
entire build to fail.

See https://discourse.slicer.org/t/no-nightly-mac-binary-since-august-1/836/10?u=jcfr

Fixes #4247
@cpinter

This comment has been minimized.

Copy link
Contributor

cpinter commented Aug 10, 2017

Wow this is great, thanks!

After this gets integrated I'll re-enable the SlicerRT tests that fail (some generic widget tests fail consistently due to being too wide etc), so that we can see if the dependencies get built on Windows as well tomorrow.

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Aug 10, 2017

Integrated in r26223

@jcfr jcfr closed this Aug 10, 2017

@jcfr jcfr deleted the jcfr:4247-extension-buildsystem-sandbox-all-steps branch Aug 10, 2017

@cpinter

This comment has been minimized.

Copy link
Contributor

cpinter commented Aug 17, 2017

I committed the change, but unfortunately SlicerRT build has not been started since the change
http://slicer.cdash.org/index.php?project=Slicer4&filtercount=1&showfilters=1&field1=label&compare1=63&value1=SlicerRT

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Aug 21, 2017

Following r26291, look like SlicerRT build has been starting as expected.

See http://slicer.cdash.org/index.php?project=Slicer4&date=2017-08-21&filtercount=1&showfilters=1&field1=label&compare1=63&value1=SlicerRT

Now looking into the MacOSx failure

@jcfr

This comment has been minimized.

Copy link
Member

jcfr commented Aug 21, 2017

@cpinter @fedorov Commit r26296 will address the MacOSX build issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment