From fe70284ec05e29f2b3bd7b12c10453dcfbb398e6 Mon Sep 17 00:00:00 2001 From: Jean-Christophe Fillion-Robin Date: Fri, 2 Sep 2016 17:38:49 -0400 Subject: [PATCH] JsonSerializationUtilities: Remove unused method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit removes method ReadJsonParameter that became obsolete after ba54510 (ENH: Allow CLI to deserialize without the required arguments) It will fix warning like this one: ``` /path/to/SlicerExecutionModel/ModuleDescriptionParser/JsonSerializationUtilities.h:43:6: warning: ‘void {anonymous}::ReadJsonParameter(const Json::Value&, std::__cxx11::string&)’ defined but not used [-Wunused-function] void ReadJsonParameter( const Json::Value & parameter, std::string & value ) ^ ``` --- .../JsonSerializationUtilities.h | 50 ------------------- 1 file changed, 50 deletions(-) diff --git a/ModuleDescriptionParser/JsonSerializationUtilities.h b/ModuleDescriptionParser/JsonSerializationUtilities.h index 4c26b55..599e966 100644 --- a/ModuleDescriptionParser/JsonSerializationUtilities.h +++ b/ModuleDescriptionParser/JsonSerializationUtilities.h @@ -19,56 +19,6 @@ namespace { -//---------------------------------------------------------------------------- -void ReadJsonParameter( const Json::Value & parameter, int & value ) -{ value = parameter.asInt(); } - -//---------------------------------------------------------------------------- -void ReadJsonParameter( const Json::Value & parameter, unsigned int & value ) -{ value = parameter.asUInt(); } - -//---------------------------------------------------------------------------- -void ReadJsonParameter( const Json::Value & parameter, float & value ) -{ value = parameter.asFloat(); } - -//---------------------------------------------------------------------------- -void ReadJsonParameter( const Json::Value & parameter, double & value ) -{ value = parameter.asDouble(); } - -//---------------------------------------------------------------------------- -void ReadJsonParameter( const Json::Value & parameter, bool & value ) -{ value = parameter.asBool(); } - -//---------------------------------------------------------------------------- -void ReadJsonParameter( const Json::Value & parameter, std::string & value ) -{ value = parameter.asString(); } - -//---------------------------------------------------------------------------- -template -void ReadJsonParameter( const Json::Value & parameter, std::vector & value ) -{ - const Json::ArrayIndex k = parameter.size(); - value.resize( k ); - for( Json::ArrayIndex i = 0; i < k; ++i ) - { - ReadJsonParameter( parameter[i], value[i] ); - } -} - -//---------------------------------------------------------------------------- -template -void ReadJsonParameter( - const Json::Value & parameters, - const char * group, const char * name, - T & value) -{ - const Json::Value & parameter = parameters[group][name]; - if( !parameter.isNull() ) - { - ReadJsonParameter( parameter, value ); - } -} - //---------------------------------------------------------------------------- template Json::Value JsonSerialize( const T & value )