Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening transforming on segmentation is slow if master representation is planar contours #102

Closed
lassoan opened this issue Feb 6, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@lassoan
Copy link
Member

commented Feb 6, 2019

How to reproduce:

  • Load segmentation
  • Create new Linear Transform
  • Set LR shift of 5 mm (any shift causes the issue)
  • Apply the transform to the ‘13 RTSTRUCT PT_MidTreat’ node
  • Click ‘Harden Transform’ button

Harden takes several minutes instead of just a few seconds.

See details here: https://discourse.slicer.org/t/harden-transform-on-large-segmentation-hangs-3d-slicer/5643/7

Sample data set:
https://unioxfordnexus-my.sharepoint.com/:u:/g/personal/donc0432_ox_ac_uk/EWFRKBv6xYZLuHqmtEkvwR4Bn9vKHM0AJFlCh9wNLMHDsw?e=YQiLwa

@cpinter

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

We observed that this only happens if the closed surface representation is visible (not sure if 2D or 3D is the reason).
A possible solution is to use DisableModified in the ApplyTransform function in the segmentation node.

@cpinter cpinter self-assigned this Feb 6, 2019

slicerbot pushed a commit to Slicer/Slicer that referenced this issue Feb 6, 2019

cpinter
BUG: Fix multiple conversions when hardening transform on segmentation
When hardening segmentation on a segmentation node containing planar contour master and closed surface, the conversion was performed multiple times, so it seemed like the application hang. Disabling an event for the hardening operation fixes this issue.

A meaningless error message about the inability to get reference image geometry when there is no labelmap representation has been removed as well.

Fixes SlicerRt/SlicerRT#102
Related to https://discourse.slicer.org/t/harden-transform-on-large-segmentation-hangs-3d-slicer/5643

git-svn-id: http://svn.slicer.org/Slicer4/trunk@27953 3bd1e089-480b-0410-8dfb-8563597acbee
@cpinter

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Fixed in commit Slicer/Slicer@3195e6d

@cpinter cpinter closed this Feb 6, 2019

sjh26 pushed a commit to Slicer/Slicer that referenced this issue May 16, 2019

sam.horvath
BUG: Fix multiple conversions when hardening transform on segmentation
Cherry-picked commit r27953

When hardening segmentation on a segmentation node containing planar contour master and closed surface, the conversion was performed multiple times, so it seemed like the application hang. Disabling an event for the hardening operation fixes this issue.

A meaningless error message about the inability to get reference image geometry when there is no labelmap representation has been removed as well.

Fixes SlicerRt/SlicerRT#102
Related to https://discourse.slicer.org/t/harden-transform-on-large-segmentation-hangs-3d-slicer/5643

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-10@28239 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.