Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the image compatible issue #77

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

LinuxSuRen
Copy link
Contributor

I found a potential image issue of the RSS parsing process. See the details below:

An image to associate with your podcast. It must not be blocked to Googlebot. You can provide an image using any of the following tags:

<itunes:image>
<image>
  <link>...</link>
  <title>...</title>
  <url>...</url>
</image>
When using RSS <image> tags, you must include a nested <link> element that points to the podcast homepage, and a nested <title> tag that matches the <title> element in the homepage.

Example: <itunes:image href="https://google.com/google_podcast_cover_art.jpg"/>

Reference

@SlyMarbo
Copy link
Owner

Hi @LinuxSuRen . Thanks for your contribution! It looks great and I'm very happy to merge the code changes.

Would it be possible to remove the change to .gitignore? I prefer to avoid anything not specific to this codebase. If it helps, you can put common things in a global .gitignore outside the repository, configured using git config --global core.excludesfile ~/.gitignore.

@LinuxSuRen
Copy link
Contributor Author

hi @SlyMarbo , thanks for your excellent suggestion. It helps a lot.

@LinuxSuRen
Copy link
Contributor Author

By the way, I'm trying to create an open-source podcast platform based on Kubernetes. I am not sure if you are interested in it. Please ignore it if you don't.

@SlyMarbo SlyMarbo merged commit deb7d6b into SlyMarbo:master Feb 15, 2022
@SlyMarbo
Copy link
Owner

That sounds really cool! I'm afraid podcasts aren't really my thing, but I wish you the best of luck.

@LinuxSuRen LinuxSuRen deleted the image branch February 15, 2022 06:35
@LinuxSuRen
Copy link
Contributor Author

LinuxSuRen commented Feb 15, 2022

Thanks for your time.
I'm wondering if it's possible to have a new git tag. For example: v1.0.2. So others can use this feature as a tag instead of a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants