Use PercentSetting to set fanSpeedPercent #2425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 466 suites 0s ⏱️ Results for commit e6561f4. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e6561f4 |
nickolas-deboom
force-pushed
the
use-fan-speed-percentage
branch
2 times, most recently
from
df06872 to
ae3bd7f
Compare
hcarter-775
reviewed
Sep 26, 2025
| local function fan_speed_percent_attr_handler(driver, device, ib, response) | ||
| local speed = 0 | ||
| if ib.data.value ~= nil then | ||
| speed = utils.clamp_value(ib.data.value, MIN_ALLOWED_PERCENT_VALUE, MAX_ALLOWED_PERCENT_VALUE) |
Contributor
There was a problem hiding this comment.
probably shouldn't remove the clamp, right?
Contributor
Author
There was a problem hiding this comment.
Restored in latest force push
hcarter-775
reviewed
Sep 29, 2025
|
|
||
| local function fan_speed_setting_attr_handler(driver, device, ib, response) | ||
| if ib.data.value == nil then return end | ||
| device:emit_event_for_endpoint(ib.endpoint_id, capabilities.fanSpeedPercent.percent(ib.data.value)) |
Contributor
There was a problem hiding this comment.
we probably want to clamp this as well
Contributor
Author
There was a problem hiding this comment.
Added in latest force push
nickolas-deboom
force-pushed
the
use-fan-speed-percentage
branch
from
ae3bd7f to
aec6e9f
Compare
This change adds the fanSpeedPercent capability to the thermostat-modular profile. Additionally, PercentSetting is subscribed in addition to PercentCurrent to set this capability, since it provides an accurate representation of the speed of the fan while helping avoid the following situation: (1) The fan speed is changed in the app and PercentSetting is routed to the device (2) The fan reports back a value of PercentCurrent that doesn't match PercentSetting because the speed takes a little while to change (3) The fanSpeedPercent capability jumps to the value reported by PercentCurrent PercentCurrent is still subscribed to, but its attribute handler is gated on the current fan mode being AUTO, in which case PercentSetting is NULL on the device side and PercentCurrent is used as a fallback for setting the capability.
nickolas-deboom
force-pushed
the
use-fan-speed-percentage
branch
from
cd97c74 to
e6561f4
Compare
nickolas-deboom
changed the base branch from
main
to
add-fan-speed-percent-for-thermostats
nickolas-deboom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PercentSetting is subscribed in addition to PercentCurrent to set
fanSpeedPercent, since it provides an accurate representation of the speed of the fan while helping avoid the following situation:(1) The fan speed is changed in the app and PercentSetting is routed to the device
(2) The fan reports back a value of PercentCurrent that doesn't match PercentSetting because the speed takes a little while to change
(3) The fanSpeedPercent capability jumps to the value reported by PercentCurrent
PercentCurrent is still subscribed to, but its attribute handler is gated on the current fan mode being AUTO, in which case PercentSetting is NULL on the device side and PercentCurrent is used as a fallback for setting the capability.