[ICP-11101] Child devices of hub connected devices not being added to room on join #11330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some hub connected DTHs were not setting the hubId when creating child devices. This was resulting in the child devices not being shown in the join screen in the app which had the side effect that they were not being added to the room the user selected when enabling join. https://smartthings.atlassian.net/browse/ICP-11101
tpmanley
commented
Sep 26, 2019
| isComponent: true, componentName: "ep$i", componentLabel: "Channel $i" | ||
| addChildDevice("Switch Child Device", | ||
| "${device.deviceNetworkId}-ep${i}", | ||
| device.hubId, |
Contributor
Author
There was a problem hiding this comment.
This is the main change. The rest is just formatting. Same in the other files
Contributor
|
|
Contributor
Author
Those two should be equivalent. It might be a different issue. |
greens
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hub connected DTHs were not setting the hubId when creating child
devices. This was resulting in the child devices not being shown in the
join screen in the app which had the side effect that they were not being
added to the room the user selected when enabling join.
https://smartthings.atlassian.net/browse/ICP-11101