ICP-770 Feature/color changes #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larsfinander for the hue values, do we want the reported value in 0-360 or in 0-100? i don't remember what was finally agreed upon. this mapping will probably affect the OCF mapping too. the zll ones right now have 360 and zigbee ha has 100. |
|
@workingmonk We always report in 100, dove/dealer takes care of converting it to 360 for OCF |
The attributes used to report Hue and Saturation can have a value of 0-254. We want to translate this to a percentage of 0-100%. The HA DTHs were dividing by 255 instead of the correct value of 254. Because the wrong divisor was used the result would be off by a percent about 25% of the time. The ZLL DTHs had the same bug plus they were also multipling the Hue by 360 instead of 100.
Previous two commands were being used to set Hue and Saturation. Now a single command is used and a transition time of 0 so the color changes must faster.
Previously we were configuring the RGB(W) and Color Temperature bulbs to report any Hue, Saturation and Color Temperature changes. Now we manually read these attributes any time a command is executed that changes them.
tpmanley
force-pushed
the
feature/color-changes
branch
from
762a697
to
522ce39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @larsfinander @tpmanley