ICP-7174 ICP-7282 ICP-7283 ICP-7308 ICP-7309 ICP-7288 ICP-7289 Misc Stelpro fixes

[dkirker]

ICP-7288 Change rounding method for temperature conversion
ICP-7308 ICP-7309 Tweaks to operating state logic (Not a full resolution)
ICP-7282 ICP-7283 Add heatingSetpoint temp unit
ICP-7174 Update Stelpro Ki logic errors

And 48eaf2b might fix part of ICP-7289

[dkirker]

I am checking to see if OneApp uses this in anyway. It didn't seem like its presence affected the range displayed in OneApp, but I want to make sure it isn't needed because of the reference to "Thermostat" in the capabilities.

This applies to all three device handlers.

[stelpro]

Donald,

Don't forget to add a check on the temperature to report a freezing alarm when the temperature is below 0°C

[dkirker]

@stelpro I did some tweaking to re-organize the handleTemperature logic.

[stelpro]

@dkirker that sounds good

[greens]

Looks good, but wait until all the bugs get confirmed first.

[dkirker]

@greens Made one addition to the zigbee DTH to work around that bug. If Poland checks out, then we can merge.

[dkirker]

@greens Alright, so the logic has changed a bit. Depending on what cert/QA says, this is probably the best we can do. I considered the route of managing the operating state ourselves, but I think that would add a bit more logic that I don't want to consider. This should at least make sure we are getting sane values, and that we have received the latest values.

[dkirker]

@rappleg or @tpmanley or @varzac Any chance I can get a +1 from any of you?
@workingmonk If we want to target this for a 1/8 deploy to production, would I need to rebase this to staging, or will there be a push from master to staging before?

[greens]

looks like you have merge conflicts now @dkirker

[dkirker]

Yeah. Looks like a weather API change. Minor. Still trying to figure out the release schedule for next week. It looks like there was already a rolling down and up of branches. But waiting for Vinay to confirm on chat.

[dkirker]

Alright, rebased to staging, and fixed indentation changes made from another commit.