From c55270d7c135ecefc0aaaf4942d6b6e62e0c9400 Mon Sep 17 00:00:00 2001
From: Maxime Queneau <maxime.queneau@smile.fr>
Date: Thu, 6 Jun 2019 11:50:55 +0200
Subject: [PATCH 1/2] [translate] Change label for harmonization translate

---
 view/adminhtml/ui_component/sales_rule_form.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/view/adminhtml/ui_component/sales_rule_form.xml b/view/adminhtml/ui_component/sales_rule_form.xml
index 1b3fc0b..fa8d5be 100644
--- a/view/adminhtml/ui_component/sales_rule_form.xml
+++ b/view/adminhtml/ui_component/sales_rule_form.xml
@@ -93,7 +93,7 @@
                     <rule name="required-entry" xsi:type="boolean">true</rule>
                 </validation>
                 <dataType>text</dataType>
-                <label translate="true">Maximum number product offered</label>
+                <label translate="true">Maximum number of products offered</label>
                 <dataScope>extension_attributes.gift_rule.maximum_number_product</dataScope>
                 <visible>false</visible>
             </settings>

From 6e205f38201ad58955d23dbcac975cfb7f986087 Mon Sep 17 00:00:00 2001
From: Maxime Queneau <maxime.queneau@smile.fr>
Date: Thu, 6 Jun 2019 14:35:38 +0200
Subject: [PATCH 2/2] [api] Issue #5 Fix rest call

---
 Api/Data/GiftRuleSearchResultsInterface.php | 4 ++--
 etc/extension_attributes.xml                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Api/Data/GiftRuleSearchResultsInterface.php b/Api/Data/GiftRuleSearchResultsInterface.php
index 20f6bf8..82baccf 100644
--- a/Api/Data/GiftRuleSearchResultsInterface.php
+++ b/Api/Data/GiftRuleSearchResultsInterface.php
@@ -27,14 +27,14 @@ interface GiftRuleSearchResultsInterface extends SearchResultsInterface
     /**
      * Get giftrule items.
      *
-     * @return GiftRuleInterface[]
+     * @return GiftRuleInterface
      */
     public function getItems();
 
     /**
      * Set giftrule items.
      *
-     * @param GiftRuleInterface[] $items Gift rule interface
+     * @param GiftRuleInterface $items Gift rule interface
      * @return $this
      */
     public function setItems(array $items);
diff --git a/etc/extension_attributes.xml b/etc/extension_attributes.xml
index 6594e13..9c5cd2e 100644
--- a/etc/extension_attributes.xml
+++ b/etc/extension_attributes.xml
@@ -15,6 +15,6 @@
  -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Api/etc/extension_attributes.xsd">
     <extension_attributes for="Magento\SalesRule\Api\Data\RuleInterface">
-        <attribute code="gift_rule" type="Smile\GiftSalesRule\Api\Data\GiftRuleInterface[]" />
+        <attribute code="gift_rule" type="Smile\GiftSalesRule\Api\Data\GiftRuleInterface" />
     </extension_attributes>
 </config>