Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in file name to Thumbnailer when saving field with "resize_source" (issue #137) #167

Merged
merged 2 commits into from Dec 19, 2012

Conversation

selwin
Copy link
Collaborator

@selwin selwin commented Sep 6, 2012

I was looking at this again to refresh my memory before tomorrow and 10 seconds later I realized that the fix is very simple.

Please take a look at this. If it's ok, I can also write a test for this.

@selwin
Copy link
Collaborator Author

selwin commented Sep 7, 2012

@SmileyChris test attached. Let me know if there's anything else you want changed.

@SmileyChris
Copy link
Owner

@selwin, I've added you as a project collaborator. I don't just want easy-thumbnails to be a "me" thing and you've been around the project long enough to know my coding style and required level of consistency. Feel free to start by committing this. Contact smileychris at gmail or catch me on freenode if you want to discuss anything.

@selwin
Copy link
Collaborator Author

selwin commented Dec 19, 2012

@SmileyChris sorry, I just came back from a holiday and am catching up on work so haven't had much time to do much else. Thanks for making me a collaborator, I'll try to pitch in when I can :)

selwin added a commit that referenced this pull request Dec 19, 2012
Pass in file name to Thumbnailer when saving field with "resize_source" (issue #137)
@selwin selwin merged commit daa81f0 into SmileyChris:master Dec 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants