Chris Beaven SmileyChris

  • New Zealand
  • Joined on

Organizations

@lincolnloop @django
@SmileyChris
Fix encoding error on some systems (e.g. Python 2.6)
SmileyChris commented on pull request lincolnloop/python-qrcode#84
@SmileyChris

Yeah, closing in favour of 80. Can you confirm that works for you @CarpeNoctem ?

SmileyChris commented on pull request lincolnloop/python-qrcode#80
@SmileyChris

I had a look at this yesterday and scratched my head as to how to accurately test this. Ideas?

SmileyChris commented on pull request lincolnloop/python-qrcode#82
@SmileyChris

I think I'm fine with the idea, even though I agree with Jacob's concerns about diluting the concept. But it should happen solely in the PIL factor…

@SmileyChris
Question: replace_alpha not used?
@SmileyChris

No, you are correct. It's probably a vestigial parameter. The only reason I can see it would be there for is that the valid options list is generat…

@SmileyChris
Question: replace_alpha not used?
@SmileyChris

Like you noticed, it's passed to the colorspace function which uses it just fine.

@SmileyChris

No, if an alias name is completely uppercase, it is simply ignored when building the options for the namer. It's a totally different case.

@SmileyChris
Thumbnails not generated for files with uppercase extensions
@SmileyChris

Duplicate of #376 (and same questions apply)

@SmileyChris

So this is for a ThumbnailerField? And an ordinary FileField (or ImageField) works? Can you define "can't upload" better - does it raise an excepti…

@SmileyChris

That's a fine idea there. I might get a chance next week, but if you want to have a crack at a pull request then fire away. Let's call the option A…

@SmileyChris

@JuanLeandro - you can use that field on a modelform too.

@SmileyChris

While it may indeed be missing, a work around would probably be to do use an alias where these options are provided. One tip is that this isn't imp…

@SmileyChris

Version 2.2 onwards covers all Exceptions, see a67f18e

@SmileyChris
@SmileyChris
  • @SmileyChris 3dd9bb5
    Document the usage of LazyTypedChoiceField for custom forms
@SmileyChris
Documenting Creating a Country Form Field
@SmileyChris

Definitely worth documenting it because this isn't actually correct :-1: If you're using a form field, you want to ensure the translatable strings fo…

@SmileyChris
  • @SmileyChris 047a0bc
    Add "United Kingdom" as a common name
@SmileyChris
Add “United Kingdom” as the common name
@SmileyChris
Countries in form (not ModelForm) not translated
@SmileyChris

You'll need to use django_countries.fields.LazyTypedChoiceField to avoid choices being cached when the form class is created.

@SmileyChris
  • @SmileyChris 9f128f4
    Pull in latest translations from transifex and compile
@SmileyChris
  • @SmileyChris 1872c1e
    Typo on common name: Moldovia -> Moldova
@SmileyChris
Moldovia vs. Moldova
@SmileyChris
  • @SmileyChris 132d43c
    Add EXIF rotation / mirroring to the meta data.
@SmileyChris
Completed missing German translation for country names. Filled in some missing Dutch translations, incomplete.
SmileyChris commented on pull request SmileyChris/django-countries#113
@SmileyChris

Sorry, I've been getting behind on my open source project responsibilities :p As the readme says, the easiest way is if you submit these as transif…