Skip to content

spiffs mounting improvements - #244

Merged
anakod merged 1 commit into
SmingHub:masterfrom
raburton:rboot
Sep 3, 2015
Merged

spiffs mounting improvements#244
anakod merged 1 commit into
SmingHub:masterfrom
raburton:rboot

Conversation

@raburton

Copy link
Copy Markdown
Member

Allows the location and length of the spiffs to be specified by the app, the app
should be compiled with DISABLE_SPIFFS to prevent auto mounting and then call
spiffs_mount_manual with the desired parameters from the init function.

This was requested by rBoot users and allows mounting of multiple different
spiffs images along side multiple OTAable rom images.

Allows the location and length of the spiffs to be specified by the app, the app
should be compiled with DISABLE_SPIFFS to prevent auto mounting and then call
spiffs_mount_manual with the desired parameters from the init function.

This was requested by rBoot users and allows mounting of multiple different
spiffs images along side multiple OTAable rom images.
@DimmKirr

Copy link
Copy Markdown
Contributor

Should it be synced with the upstream? https://github.com/pellepl/spiffs

@raburton

Copy link
Copy Markdown
Member Author

Should it be synced with the upstream? https://github.com/pellepl/spiffs

I don't think so, none of the code altered exists upstream. spiffs.c isn't there at all and the small change to the declarations in spiffs.h aren't in the upstream version.

@DimmKirr

Copy link
Copy Markdown
Contributor

Ah, You're right. spiffs.c is sming-specific.

On Sat, Aug 29, 2015 at 11:41 AM, Richard Antony Burton <
notifications@github.com> wrote:

Should it be synced with the upstream? https://github.com/pellepl/spiffs

I don't think so, none of the code altered exists upstream. spiffs.c isn't
there at all and the small change to the declarations in spiffs.h aren't in
the upstream version.


Reply to this email directly or view it on GitHub
#244 (comment).

@piperpilot

Copy link
Copy Markdown
Contributor

Richard,

I don't see a change to support bypassing the spiffs_mount() in user_main.cpp. Above you mention "DISABLE_SPIFFS"...did you forget to commit the change for that?

Curtis

EDIT: actually looking at the recent merges, there was a change by "Andrei Diea" that adds the "DISABLE_SPIFFS" variable and example to the CFLAGS.

@raburton

Copy link
Copy Markdown
Member Author

That's right, it's already there from a recent commit. It saved me having to add something similar myself.

@anakod

anakod commented Sep 3, 2015

Copy link
Copy Markdown
Member

I think that's right direction for lager flash chips, thank you.

anakod added a commit that referenced this pull request Sep 3, 2015
+ spiffs manual mounting
@anakod
anakod merged commit d8ff26b into SmingHub:master Sep 3, 2015
This was referenced Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants